[Checkins] SVN: lovely.remotetask/trunk/ fix bug in "Jobs" view and bump version

Benji York benji at zope.com
Tue Aug 7 10:35:37 EDT 2007


Log message for revision 78671:
  fix bug in "Jobs" view and bump version
  

Changed:
  U   lovely.remotetask/trunk/CHANGES.txt
  U   lovely.remotetask/trunk/setup.py
  U   lovely.remotetask/trunk/src/lovely/remotetask/browser/service.py

-=-
Modified: lovely.remotetask/trunk/CHANGES.txt
===================================================================
--- lovely.remotetask/trunk/CHANGES.txt	2007-08-07 14:09:35 UTC (rev 78670)
+++ lovely.remotetask/trunk/CHANGES.txt	2007-08-07 14:35:37 UTC (rev 78671)
@@ -2,9 +2,14 @@
 Changes for lovely.remotetask
 =============================
 
-after 0.2.5:
+after 0.2.7:
 ============
 
+2007/08/07 0.2.6:
+=================
+
+- fix bug in sorting that causes column headers to never be clickable
+
 2007/08/07 0.2.5:
 =================
 

Modified: lovely.remotetask/trunk/setup.py
===================================================================
--- lovely.remotetask/trunk/setup.py	2007-08-07 14:09:35 UTC (rev 78670)
+++ lovely.remotetask/trunk/setup.py	2007-08-07 14:35:37 UTC (rev 78671)
@@ -3,7 +3,7 @@
 
 setup (
     name='lovely.remotetask',
-    version='0.2.5',
+    version='0.2.6',
     author = "Lovely Systems",
     author_email = "office at lovelysystems.com",
     description = "A remotetask client utiltiy for zope 3",

Modified: lovely.remotetask/trunk/src/lovely/remotetask/browser/service.py
===================================================================
--- lovely.remotetask/trunk/src/lovely/remotetask/browser/service.py	2007-08-07 14:09:35 UTC (rev 78670)
+++ lovely.remotetask/trunk/src/lovely/remotetask/browser/service.py	2007-08-07 14:35:37 UTC (rev 78671)
@@ -208,6 +208,7 @@
     sortedHeaderTemplate = ViewPageTemplateFile('table_header.pt')
     widths = None
     columnCSS = None
+    sortable = False
 
     def __init__(self, *args, **kw):
         # Figure out sorting situation
@@ -218,6 +219,7 @@
 
         session = zope.component.queryAdapter(request, ISession)
         if session is not None:
+            self.sortable = True
             session = session[SORTED_ON_KEY]
 
             if 'sort-on' in request:
@@ -246,7 +248,7 @@
     # sortable table support via session
     def getHeader(self, column):
         contents = column.renderHeader(self)
-        if self.sortOn != (None, None) and ISortableColumn.providedBy(column):
+        if self.sortable and ISortableColumn.providedBy(column):
             contents = self._wrapInSortUI(contents, column)
         return contents
 



More information about the Checkins mailing list