[Checkins] Re: SVN: zope.sendmail/trunk/src/zope/sendmail/ merging

[Philipp von Weitershausen]

Baiju M wrote:
> Andreas Jung wrote:
>> Log message for revision 79001:
>>   merging
>>     
>> svn+ssh://svn.zope.org/repos/main/zope.sendmail/branches/ajung-encryption-branch 
>>
>>     This branch provides TLS/SSL encryption support.
> There are two errors from zope.sendmail, like:
> Error in test test_send (zope.sendmail.tests.test_mailer.TestSMTPMailer)
> Traceback (most recent call last):
>  File "/baiju/usr//lib/python2.4/unittest.py", line 260, in run
>    testMethod()
>  File 
> "/home/baiju/wa/zope.sendmail/src/zope/sendmail/tests/test_mailer.py", 
> line 68, in test_send
>    self.mailer.send(fromaddr, toaddrs, msgtext)
>  File "/home/baiju/wa/zope.sendmail/src/zope/sendmail/mailer.py", line 
> 49, in send
>    code, response = connection.ehlo()
> AttributeError: 'SMTP' object has no attribute 'ehlo'
> 
> Please modify SMTP mock object to run the test.  I just tried to do
> this and it's working, please verify it:
> ...

Also, this features lacks tests of its own. Andreas, could you please 
fix the existing tests and provide tests for the new feature?

Thanks


-- 
http://worldcookery.com -- Professional Zope documentation and training