[Checkins] SVN: z3c.form/trunk/ Make NOT_CHANGED not inherit str.
Dan Korostelev
nadako at gmail.com
Mon Feb 9 22:10:01 EST 2009
2009/2/10 Stephan Richter <srichter at cosmos.phy.tufts.edu>:
> On Monday 09 February 2009, Dan Korostelev wrote:
>> XXX: Should'nt NOT_CHANGED be renamed to NOTCHANGED to follow the same
>> naming style as NOVALUE, while it's not late to do so?
>
> According to PEP8 and the convention that I usually use is to have the
> underscore. Don't ask me why I did it differently for NOVALUE. For sake of
> consistency I would be ok to change it to NOTCHANGED, though I would also
> support a change to NO_VALUE, since this is a new major release.
The change to NO_VALUE looks right to me, as we really use underscores
in other constants, like INPUT_MODE and so on. We could provide a
backward-compatibility NOVALUE name not to break much people code.So,
should I do that? :-)
--
WBR, Dan Korostelev
More information about the Checkins
mailing list