[Checkins] SVN: ZConfig/trunk/ - Added SMTP authentication support for email logger on Python 2.6.

[Christian Zagrodnick]

On 10.04.2010, at 16:21, Fred Drake wrote:

> On Sat, Apr 10, 2010 at 8:12 AM, Christian Zagrodnick <cz at gocept.com> wrote:
>> Log message for revision 110705:
>>  - Added SMTP authentication support for email logger on Python 2.6.
> 
> Cool!
> 
>> Changed:
>>  U   ZConfig/trunk/NEWS.txt
>>  U   ZConfig/trunk/ZConfig/components/logger/handlers.py
>>  U   ZConfig/trunk/ZConfig/components/logger/handlers.xml
>>  U   ZConfig/trunk/ZConfig/components/logger/tests/test_logger.py
> 
> I notice the documentation wasn't updated, and also that the email
> handler isn't mentioned at all in the docs.

Oh, sure. Completely forgot documentation. 

> 
> Would you like to contribute a patch for that?
> 
>> Modified: ZConfig/trunk/ZConfig/components/logger/handlers.xml
> ...
>> +    <key name="smtp-auth-username" default="" datatype="string"/>
>> +    <key name="smtp-auth-password" default="" datatype="string"/>
> 
> Why not "smtp-username" and "smtp-password"?  I think that would be
> clear.  Authentication is about the only thing we'd want with that
> information, so that shouldn't require calling out.

Sounds good.

>> +    def test_with_email_notifier_with_credentials(self):
> 
> Shouldn't there also be tests that show what happens when only one of
> username and password is provided?  And shouldn't that be checked for
> and turned into an error?

Right, it's probably save to assume that username and password are not useful witout the other.


-- 
Christian Zagrodnick · cz at gocept.com
gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1
Zope and Plone consulting and development

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4221 bytes
Desc: not available
Url : http://mail.zope.org/pipermail/checkins/attachments/20100412/43148319/attachment.bin