[Checkins] [zopefoundation/zdaemon] 7f8254: Use 'with lock:' instead of acquire()/release()

GitHub noreply at github.com
Wed Apr 15 18:53:47 CEST 2015


  Branch: refs/heads/master
  Home:   https://github.com/zopefoundation/zdaemon
  Commit: 7f8254841a49c9f699acf0a2334e430029b8424a
      https://github.com/zopefoundation/zdaemon/commit/7f8254841a49c9f699acf0a2334e430029b8424a
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2015-04-15 (Wed, 15 Apr 2015)

  Changed paths:
    M src/zdaemon/zdrun.py

  Log Message:
  -----------
  Use 'with lock:' instead of acquire()/release()

This could prevent deadlocks like #1, although not that specific one.


  Commit: b346f863905cb873e927c6fbb485f1c5ff00e290
      https://github.com/zopefoundation/zdaemon/commit/b346f863905cb873e927c6fbb485f1c5ff00e290
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2015-04-15 (Wed, 15 Apr 2015)

  Changed paths:
    M src/zdaemon/zdrun.py

  Log Message:
  -----------
  Don't close self.file before we know we can reopen it

If file permissions change, reopening will fail, and we'll end up
getting an exception, a closed self.file, and a background thread that
will die next time it tries to write to the now-closed file, leaving the
child process writing to a pipe until the pipe buffer fills up at some
point in the future (see also bug #1).


  Commit: ae3cd749fb6e5aa92fa8e82fbbc91727761e0959
      https://github.com/zopefoundation/zdaemon/commit/ae3cd749fb6e5aa92fa8e82fbbc91727761e0959
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2015-04-15 (Wed, 15 Apr 2015)

  Changed paths:
    M src/zdaemon/tests/testzdctl.py
    M src/zdaemon/zdctl.py

  Log Message:
  -----------
  Resurrect logreopen (#10)


  Commit: b02276f67597b0d78117606e12da1c6959e9db5b
      https://github.com/zopefoundation/zdaemon/commit/b02276f67597b0d78117606e12da1c6959e9db5b
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2015-04-15 (Wed, 15 Apr 2015)

  Changed paths:
    M src/zdaemon/tests/tests.py
    M src/zdaemon/zdctl.py

  Log Message:
  -----------
  Don't ignore 'stop' if the program is respawning (#13)

Conveniently this bug was discovered while writing a test for the
previous feature (#10), so we save one test ;)


Compare: https://github.com/zopefoundation/zdaemon/compare/a7c14068c5c9...b02276f67597


More information about the checkins mailing list