[Checkins] [zopefoundation/z3c.form] 6708c3: Fixed possible UnicodeDecodeError in setup.py on P...

Maurits van Rees noreply at github.com
Fri Sep 4 16:57:43 CEST 2020


  Branch: refs/heads/3.x
  Home:   https://github.com/zopefoundation/z3c.form
  Commit: 6708c329a037a678bfa067b991b12d851ccdc229
      https://github.com/zopefoundation/z3c.form/commit/6708c329a037a678bfa067b991b12d851ccdc229
  Author: Maurits van Rees <maurits at vanrees.org>
  Date:   2020-09-04 (Fri, 04 Sep 2020)

  Changed paths:
    M CHANGES.txt
    M README.txt
    M setup.cfg
    M setup.py

  Log Message:
  -----------
  Fixed possible UnicodeDecodeError in setup.py on Python 3.6.

Put the long description in setup.cfg, without replacing characters.
See this error on Plone Jenkins, https://jenkins.plone.org/job/plone-5.2-python-3.6/1058/console

```
Develop: '/home/jenkins/workspace/plone-5.2-python-3.6/src/z3c.form'
Traceback (most recent call last):
  File "/tmp/tmps_fh_how", line 14, in <module>
    exec(compile(f.read(), '/home/jenkins/workspace/plone-5.2-python-3.6/src/z3c.form/setup.py', 'exec'))
  File "/home/jenkins/workspace/plone-5.2-python-3.6/src/z3c.form/setup.py", line 61, in <module>
    'util.txt',
  File "/home/jenkins/workspace/plone-5.2-python-3.6/src/z3c.form/setup.py", line 46, in <listcomp>
    for name in ('README.txt',
  File "/home/jenkins/workspace/plone-5.2-python-3.6/src/z3c.form/setup.py", line 22, in read
    text = f.read()
  File "/home/jenkins/shiningpanda/jobs/65a48de5/virtualenvs/d41d8cd9/lib/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 752: ordinal not in range(128)
While:
  Installing.
  Processing develop directory '/home/jenkins/workspace/plone-5.2-python-3.6/src/z3c.form'.
```

I have seen it go wrong for more packages the last couple of months.
Locally I see no problem with Python 3.6, so it *could* be a problem only on one Jenkins node.
But if it happens there, it might happen for other users too.

See another package where I initially fixed it by hacking something in `setup.py`,
and then replaced it with `setup.cfg` in this commit:
https://github.com/plone/Products.CMFPlacefulWorkflow/commit/eda6670f50436d2dea426a389563df1223760978


  Commit: 69b18ea82fcaba76963465b3de6794c8ac084c50
      https://github.com/zopefoundation/z3c.form/commit/69b18ea82fcaba76963465b3de6794c8ac084c50
  Author: Maurits van Rees <m.van.rees at zestsoftware.nl>
  Date:   2020-09-04 (Fri, 04 Sep 2020)

  Changed paths:
    M CHANGES.txt
    M README.txt
    M setup.cfg
    M setup.py

  Log Message:
  -----------
  Merge pull request #98 from zopefoundation/maurits/fix-unicode-decode-error-setup-py-3x

Fixed possible UnicodeDecodeError in setup.py on Python 3.6. [3.x]


Compare: https://github.com/zopefoundation/z3c.form/compare/08d834b3ad2d...69b18ea82fca


More information about the checkins mailing list