<div dir="ltr"><br><br><div class="gmail_quote">On Fri, Jul 11, 2008 at 3:35 PM, Philipp von Weitershausen <span dir="ltr"><<a href="mailto:philipp@weitershausen.de">philipp@weitershausen.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">Tarek Ziade wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Log message for revision 87237:<br>
merged the allow-hosts option<br>
<br>
Changed:<br>
U zc.buildout/trunk/CHANGES.txt<br>
A zc.buildout/trunk/src/zc/buildout/allowhosts.txt<br>
U zc.buildout/trunk/src/zc/buildout/buildout.py<br>
U zc.buildout/trunk/src/zc/buildout/buildout.txt<br>
U zc.buildout/trunk/src/zc/buildout/easy_install.py<br>
U zc.buildout/trunk/src/zc/buildout/tests.py<br>
U zc.buildout/trunk/zc.recipe.egg_/src/zc/recipe/egg/egg.py<br>
<br>
-=-<br>
Modified: zc.buildout/trunk/CHANGES.txt<br>
===================================================================<br>
--- zc.buildout/trunk/CHANGES.txt 2008-06-07 22:08:05 UTC (rev 87236)<br>
+++ zc.buildout/trunk/CHANGES.txt 2008-06-07 23:16:44 UTC (rev 87237)<br>
@@ -7,6 +7,8 @@<br>
1.0.4 (unreleased)<br>
==================<br>
+- Added the `allow-hosts` option (tarek)<br>
+<br>
</blockquote></div>
...<div class="Ih2E3d"><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Modified: zc.buildout/trunk/zc.recipe.egg_/src/zc/recipe/egg/egg.py<br>
===================================================================<br>
--- zc.buildout/trunk/zc.recipe.egg_/src/zc/recipe/egg/egg.py 2008-06-07 22:08:05 UTC (rev 87236)<br>
+++ zc.buildout/trunk/zc.recipe.egg_/src/zc/recipe/egg/egg.py 2008-06-07 23:16:44 UTC (rev 87237)<br>
@@ -39,6 +39,11 @@<br>
options['index'] = index<br>
self.index = index<br>
<br>
</blockquote></div>
...<div class="Ih2E3d"><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
@@ -78,6 +83,7 @@<br>
always_unzip=options.get('unzip') == 'true',<br>
path=[options['develop-eggs-directory']],<br>
newest=self.buildout['buildout'].get('newest') == 'true',<br>
+ allow_hosts=self.allow_hosts<br>
)<br>
</blockquote>
<br></div>
Tarek,<br>
<br>
you added the allow_hosts option to zc.buildout and made zc.recipe.egg use it. The problem with that is that they're independent eggs and could be upgraded independently from each other. In this case, if you got the newer zc.recipe.egg but still an older zc.buildout, things would break. It's therefore necessary to declare in zc.recipe.egg that it needs *at least* zc.buildout 1.0.6 or whatever the version was that contained the allow_hosts option first. In other words, zc.recipe.egg's dependency should have stated<br>
<br>
zc.buildout>=1.0.6</blockquote><div><br>Good catch, I'll change that<br><br>Thx<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
I wonder why zc.recipe.egg is actually a part of the zc.buildout tree. Woudln't it be easier to just have it as a top-level project in svn?<br>
</blockquote></div><br>+1 this is annoying,<br><br>Tarek<br clear="all"><br>-- <br>Tarek Ziadé | Association AfPy | <a href="http://www.afpy.org">www.afpy.org</a><br>Blog FR | <a href="http://programmation-python.org">http://programmation-python.org</a><br>
Blog EN | <a href="http://tarekziade.wordpress.com/">http://tarekziade.wordpress.com/</a><br>
</div>