[Zope-Coders] Re: [Zope-Checkins] CVS: Zope3/lib/python/Zope/App/OFS/Memento - AttributeMementoBag.py:1.1.2.1 IAttributeMementoStorable.py:1.1.2.1 IMementoBag.py:1.1.2.1 __init__.py:1.1.2.1

Steve Alexander steve@cat-box.net
Sat, 23 Mar 2002 18:43:35 +0000


Florent Guillaume wrote:
> R. David Murray <rdmurray@bitdance.com> wrote:
> 
>>=== Added File Zope3/lib/python/Zope/App/OFS/Memento/AttributeMementoBag.py ===
> 
> [...]
> 
>>class AttributeMementoBag:
>>
>>    """
>>    Store memento bag data in the __membag__ attribute on a
>>    IAttributeMementoStorable object.
>>    """
>>
>>    def __init__(self,obj):
>>        if not hasattr(obj,'__memobag__'): obj.__memobag__ = OOBTree()
>>        self.obj = obj
> 
> 
> I'd rather see this called __mementobag__, why the gratuitous
> inconsistency ? (Admitedly it's an implementation detail, but even
> then...)
> 
> Also the docstring naming is inconsistent (in several places).


Sure, but they are sprinting!  Please give them a chance to get through 
an iteration or two!

--
Steve Alexander