[Zope-Coders] Back in town

[Andreas Jung]

Is this issue now resolved with your fixes? At least from my point of view 
the unittests are
running for the latest 2.7 checkout.

Andreas

--On Samstag, 4. September 2004 22:44 Uhr -0400 Chris McDonough 
<chrism at plope.com> wrote:

> Beautiful, thank you!  I have committed this.
>
> The failing test (caused by a run against a Zope *without* your
> Publish.py patches) is a nice dose of clarity.
>
> ======================================================================
> ERROR: doctest of ZPublisher.tests.testPublish.testPublisher
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/chrism/opt/Python-2.3.4/lib/python2.3/unittest.py", line
> 423, in runTest
>     self.__testFunc()
>   File "/home/chrism/opt/Python-2.3.4/lib/python2.3/doctest.py", line
> 1359, in runit
>     _utest(tester, name, doc, filename, lineno)
>   File "/home/chrism/opt/Python-2.3.4/lib/python2.3/doctest.py", line
> 1309, in _utest
>     raise DocTestTestFailure('Failed doctest test for %s\n'
> DocTestTestFailure: Failed doctest test for
> ZPublisher.tests.testPublish.testPublisher
>   File
> "/home/chrism/software/27Branch/lib/python/ZPublisher/tests/testPublish.p
> y", line 126, in testPublisher
> *****************************************************************
> Failure in example: tracer.showTracedPath()
> from line #47 of ZPublisher.tests.testPublish.testPublisher
> Expected:
> begin
> __call__
> raising ValueError from __call__
> zpublisher_exception_hook
> raising ValueError from zpublisher_exception_hook
> abort
> Got:
> begin
> __call__
> raising ValueError from __call__
> zpublisher_exception_hook
> raising ValueError from zpublisher_exception_hook
> *****************************************************************
> Failure in example: tracer.showTracedPath()
> from line #103 of ZPublisher.tests.testPublish.testPublisher
> Expected:
> begin
> __call__
> raising ConflictError from __call__
> abort
> begin
> __call__
> raising ConflictError from __call__
> abort
> begin
> __call__
> raising ConflictError from __call__
> abort
> begin
> __call__
> raising ConflictError from __call__
> abort
> Got:
> begin
> __call__
> raising ConflictError from __call__
> abort
> begin
> __call__
> raising ConflictError from __call__
> abort
> begin
> __call__
> raising ConflictError from __call__
> abort
> begin
> __call__
> raising ConflictError from __call__
> *****************************************************************
> Failure in example: tracer.showTracedPath()
> from line #132 of ZPublisher.tests.testPublish.testPublisher
> Expected:
> begin
> __call__
> raising ValueError from __call__
> zpublisher_exception_hook
> raising ConflictError from zpublisher_exception_hook
> abort
> Got:
> begin
> __call__
> raising ValueError from __call__
> zpublisher_exception_hook
> raising ConflictError from zpublisher_exception_hook
>
>
> On Sat, 2004-09-04 at 16:46, Michael Dunstan wrote:
>> On 5/09/2004, at 5:03 AM, Jens Vagelpohl wrote:
>>
>> >
>> > On Sep 4, 2004, at 16:54, Andreas Jung wrote:
>> >
>> >> Hi,
>> >>
>> >> I am back from vacation. Can someone update me about the necessity of
>> >> 2.7.3 release
>> >> and the status of code on the SVN trunk (for a planned 2.8 released
>> >> this month)?
>> >
>> > IMHO 2.7.3 is needed. There were some very important ZODB fixes from
>> > Tim, among other things.
>>
>> I think it would be useful to get the attached patch into 2.7.3.
>>
>> It is a fix to ensure that all transaction are always either commited
>> or aborted. Previously if an error bubbled up to Zope's publishing
>> machinery during execution of the publishing error handler then the
>> transaction was not aborted. (It would have been aborted from the begin
>> of the following transaction but that has been recently advertised as
>> non-ideal.)
>>
>> It is the same patch that I have posted before to zope-dev. This one
>> though includes a test for that. Chris has replied off line and is
>> comfortable with this.
>>
>> I've been using this in testing sessions using latest of 2_7-branch -
>> includes ZODB fixes from Tim. So far it seems that this patch is a
>> pretty important step to ironing out a lot of the problems with
>> sessions.
>>
>> Any objections?
>>
>> michael
>>
>>
>> ______________________________________________________________________
>> _______________________________________________
>> Zope-Coders mailing list
>> Zope-Coders at zope.org
>> http://mail.zope.org/mailman/listinfo/zope-coders
>
> _______________________________________________
> Zope-Coders mailing list
> Zope-Coders at zope.org
> http://mail.zope.org/mailman/listinfo/zope-coders