[ZCM] [ZC] 873/ 4 Resolve "SiteErrorLog shows only useless HTML-Tags for NotFound-Exception"

Collector: Zope Bugs, Features, and Patches ... zope-coders-admin@zope.org
Tue, 29 Apr 2003 11:14:50 -0400


Issue #873 Update (Resolve) "SiteErrorLog shows only useless HTML-Tags for NotFound-Exception"
 Status Resolved, Zope/bug+solution low
To followup, visit:
  http://collector.zope.org/Zope/873

==============================================================
= Resolve - Entry #4 by efge on Apr 29, 2003 11:14 am

 Status: Pending => Resolved

Resolved in CVS.

________________________________________
= Comment - Entry #3 by mjablonski on Apr 29, 2003 3:47 am

Thanks Evan,

I didn't notice your fix. Sorry for that. This issue can be closed.
________________________________________
= Comment - Entry #2 by evan on Apr 25, 2003 12:37 pm

This is fixed in the CVS trunk.  I didn't check it into the 2.6 branch, since I'm not sure it really qualifies as a bug fix rather than a feature.
________________________________________
= Request - Entry #1 by mjablonski on Apr 8, 2003 5:22 am

I would like to introduce a small change into SiteErrorLog. If you visit the error_log in the ZMI, you'll see many entries like:

21:42:06         Anonymous User (None)         NotFound: <TABLE BORDER="0" WIDTH="100%"> <TR VALIGN="TOP"> <TD WIDTH="10%"

The "Exception Value" for the ExceptionType "NotFound" is useless this way. Much more useful would be an entry like:

21:42:06         Anonymous User (None)         NotFound: http://localhost:8080/url/not/found

The only thing which needs a little patch is python/lib/Products/SiteErrorLog/www/main.pt:

87c87,88
<       tal:content="python: len(value) < 70 and value or value[:70] + '...'">
---
>       tal:content="python: test(entry['type']=='NotFound',
>       entry['url'], len(value) < 70 and value or value[:70] + '...')">


Casey Duncan commented on zope-dev: "It seems reasonable to me to single this one out since its so common."

==============================================================