[ZCM] [ZC] 888/ 3 Reject "Make getPhysicalPath take optional 'join' param"

Collector: Zope Bugs, Features, and Patches ... zope-coders-admin@zope.org
Sat, 07 Jun 2003 11:41:42 -0400


Issue #888 Update (Reject) "Make getPhysicalPath take optional 'join' param"
 Status Rejected, Zope/feature+solution medium
To followup, visit:
  http://collector.zope.org/Zope/888

==============================================================
= Reject - Entry #3 by ajung on Jun 7, 2003 11:41 am

 Status: Pending => Rejected

I am rejecting this since an application might get a wrong physical  path from an object that overrides getPhysicalPath() but no an
implementation for getPhysicalPathAsString(). getPhysicalPathAsString() can be implemented very easily on the application side.

-aj
________________________________________
= Comment - Entry #2 by efge on Apr 23, 2003 5:02 pm

Why slow down a perfectly good function that does its job?
If this is really needed, I'd prefer the creation of a
getPhysicalPathAsString() method instead.

________________________________________
= Request - Entry #1 by Anonymous User on Apr 23, 2003 4:10 pm

Code is trivial, simply do a test for the optional join parameter.    This is purely for convenience....

def getPhysicalPath(self, join=0):
  ....
  if join:
    return '/'.join(path)
  else:
    return path
==============================================================