[ZCM] [ZC] 1443/ 7 Comment "webdav.xmltools xml request parser memory leak"

[Collector: Zope Bugs, Features, and Patches ...]

Issue #1443 Update (Comment) "webdav.xmltools xml request parser memory leak"
 Status Resolved, Zope/bug+solution medium
To followup, visit:
  http://collector.zope.org/Zope/1443

==============================================================
= Comment - Entry #7 by longsleep on Oct 31, 2004 7:10 pm


Uploaded:  "xmltools-fixes-1.diff"
 - http://collector.zope.org/Zope/1443/xmltools-fixes-1.diff/view
after some tests with plain zope i discovered a couple of issues with this patch. I managed to fix most of them, and even figured out the reasons for del_attr and remap methods.

Attached is a patch for this stuff to the current zope 2.7 cvs branch.

One thing needs more attention .. see issue #1561 at http://zope.org/Collectors/Zope/1561

________________________________________
= Resolve - Entry #6 by ajung on Oct 31, 2004 2:22 pm

 Status: Pending => Resolved

Patch applied for Zope 2.7.4, 2.8a2.

________________________________________
= Comment - Entry #5 by longsleep on Oct 31, 2004 11:59 am


Uploaded:  "webdav.xmltools.minidom-20041031.patch"
 - http://collector.zope.org/Zope/1443/webdav.xmltools.minidom-20041031.patch/view
Ok. Attached is a patch against 2.7.3. This patch should work with svn trunk as well as there have been no changes to xmltools for a while.
________________________________________
= Comment - Entry #4 by ajung on Oct 30, 2004 4:00 am

Could make your stuff available as patch against the 2.7/2.8 sources?


________________________________________
= Comment - Entry #3 by longsleep on Sep 18, 2004 6:29 am


Uploaded:  "iPatch_xmltools-0.2.tar.gz"
 - http://collector.zope.org/Zope/1443/iPatch_xmltools-0.2.tar.gz/view
corrected some bugs in version 0.1 and released 0.2 version of the patch. Get it from http://longsleep.org/downloads/iPatch_xmltools-0.2.tar.gz/file_view   or use the attached file
________________________________________
= Comment - Entry #2 by ajung on Jul 30, 2004 12:45 am

Looks like a candidate for Zope 2.8. I have some fear
putting this untested into Zope 2.7.
________________________________________
= Request - Entry #1 by longsleep on Jul 29, 2004 5:33 am


Uploaded:  "iPatch_xmltools-0.1.tar.gz"
 - http://collector.zope.org/Zope/1443/iPatch_xmltools-0.1.tar.gz/view
When webdav request contain an xml body this xml string is parsed using a xmllib based xml parser. This xmlparser leaks one instance of the parsed xml file for each request. This leads to MemoryError when having lots of such requests. I wasnt able to track this down inside the webdav.xmltools module so i rewrote the parser using minidom and published a monkey patch product. Get the file either from http://longsleep.org/downloads/iPatch_xmltools-0.1.tar.gz/file_view or use the attachment.
==============================================================