[ZCM] [ZC] 1812/ 4 Resolve "Z SQL test in the ZMI aborts on key error"

[Collector: Zope Bugs, Features, and Patches ...]

Issue #1812 Update (Resolve) "Z SQL test in the ZMI aborts on key error"
 Status Resolved, Zope/bug+solution medium
To followup, visit:
  http://www.zope.org/Collectors/Zope/1812

==============================================================
= Resolve - Entry #4 by ajung on Jul 2, 2005 5:00 am

 Status: Pending => Resolved

Applied patch to 2.7, 2.8 branch, svn trunk
________________________________________
= Edit - Entry #3 by tseaver on Jun 20, 2005 8:53 am

 Changes: submitter email, classification (bug => bug+solution), new comment

Mark as "low-hanging fruit."
________________________________________
= Comment - Entry #2 by tseaver on Jun 20, 2005 8:52 am


Uploaded:  "zsql_batching.patch"
 - http://www.zope.org/Collectors/Zope/1812/zsql_batching.patch/view
I'm uploading a patch which should correct this issue.
________________________________________
= Request - Entry #1 by allison on Jun 20, 2005 5:25 am

Subject: Z SQL test in the ZMI aborts on key error

Zope 2.7.6, Python 2.3.5, MySQLDA-1.2.1c3, ZMYSQLDA-2.09b3

Site Error
An error was encountered while publishing this resource.
Error Type: KeyError
Error Value: 'query'
----------
Error log:

 2005/06/07 03:33:03.344 GMT-7
User Name (User Id) allison (allison)
Request URL http://group1.agilemind.com/Scratch/simpleq/manage_test
Exception Type KeyError
Exception Value 'query'

Traceback (innermost last):

    * Module ZPublisher.Publish, line 101, in publish
    * Module ZPublisher.mapply, line 88, in mapply
    * Module ZPublisher.Publish, line 39, in call_object
    * Module Shared.DC.ZRDB.DA, line 337, in manage_test
    * Module DocumentTemplate.DT_String, line 474, in __call__
    * Module DocumentTemplate.DT_In, line 602, in renderwb
    * Module DocumentTemplate.DT_Var, line 219, in render

KeyError: 'query'

There does not seem to be a bug like this in the collectors.
--- 
There was some discussion of this and tseever provided the following patch which I have tested and it works.  The patch context may be incorrect for the 2.7.6 release.  In my case, I simply added the
    missing=''
which resolved the problems.
----

customDefaultReport.dtml    Wed Jun  8 14:26:14 2005
+++ Zope2.7/lib/python/Shared/DC/ZRDB/dtml/customDefaultReport.dtml     Wed Jun  8 13:09:22 2005
@@ -3,7 +3,7 @@

       <dtml-if previous-sequence>

-        <a href="&dtml-URL;?query_start=&dtml-previous-sequence-start-number;&query=<dtml-var query url_quote missing=''>">
+        <a href="&dtml-URL;?query_start=&dtml-previous-sequence-start-number;&query=<dtml-var query url_quote>">
         (Previous <dtml-var previous-sequence-size> results)
         </a>

@@ -22,7 +22,7 @@
       %(else no_table)[</table>%(else)]

       <dtml-if next-sequence>
-         <a href="&dtml-URL;?query_start=&dtml-next-sequence-start-number;&query=<dtml-var query url_quote missing=''>
+         <a href="&dtml-URL;?query_start=&dtml-next-sequence-start-number;&query=<dtml-var query url_quote>">

          (Next <dtml-var next-sequence-size> results)
          </a>
@@ -35,5 +35,3 @@
   There was no data matching this &dtml-title_or_id; query.

 </dtml-in>

---------------


==============================================================