[ZCM] [ZC] 2160/ 2 Resolve "ZCatalog uses "savepoint" inadequately"

[Collector: Zope Bugs, Features, and Patches ...]

Issue #2160 Update (Resolve) "ZCatalog uses "savepoint" inadequately"
 Status Resolved, Catalog/bug+solution medium
To followup, visit:
  http://www.zope.org/Collectors/Zope/2160

==============================================================
= Resolve - Entry #2 by tseaver on Jul 27, 2006 11:05 am

 Status: Pending => Resolved

Already fixed on 2.8 branch:

  Revision:   39977
  Author:     chrisw
  Date:       Tue Nov 8 15:19:40 2005 UTC (8 months, 2 weeks ago)

  Log Message:

  this spelling lets non-savepoint aware TM's (like DA's) stand a chance

and likewise on the trunk at that date (which became 2.9) in revision 39976.

________________________________________
= Request - Entry #1 by d.maurer on Jul 27, 2006 8:16 am


Uploaded:  "ZCatalog-savepoint.pat"
 - http://www.zope.org/Collectors/Zope/2160/ZCatalog-savepoint.pat/view
Formerly, ZCatalog contained a subtransaction.commit (to free resources). As now subtransactions are deprecated, someone tried to emulated the commit by means of "savepoint" and forgot the "optimistic=True" parameter.

As a consequence large transactions modifying data in a non "savepoint" capable datamanager (e.g. via a relational database adapter) will fail with a TypeError as soon as they reach the subtransaction threshold of the catalog.
==============================================================