[ZCM] [ZC] 2073/ 6 Assign "misbehaviour of OFS.Owned.changeOwnership"

[Collector: Zope Bugs, Features, and Patches ...]

Issue #2073 Update (Assign) "misbehaviour of OFS.Owned.changeOwnership"
 Status Accepted, Zope/bug+solution medium
To followup, visit:
  http://www.zope.org/Collectors/Zope/2073

==============================================================
= Assign - Entry #6 by ajung on Jun 10, 2006 9:41 am

 Status: Pending => Accepted

 Supporters added: ajung, andreasjung

Assigning to myself to apply patch later
________________________________________
= Comment - Entry #5 by sbunse on Apr 24, 2006 9:27 pm

please read 2.8.4 as 2.8.5 in my previous comment... it's late ;)
________________________________________
= Comment - Entry #4 by sbunse on Apr 24, 2006 9:25 pm


Uploaded:  "testChownRecursive.py"
 - http://www.zope.org/Collectors/Zope/2073/testChownRecursive.py/view
i just wrote a ZopeTestCase for this problem. in the meantime i upgraded to zope 2.8.6, but there was no change in changeOwnership since 2.8.4.
with 2.8.6 the test fails with unpatched zope and succeeds after proposed change.
________________________________________
= Comment - Entry #3 by sbunse on Apr 21, 2006 11:41 am

currently i have no time to learn writing unittests but i'll do as soon as possible.
________________________________________
= Comment - Entry #2 by ajung on Apr 21, 2006 11:08 am

Could you please provide a unittest for the patch?
________________________________________
= Request - Entry #1 by sbunse on Apr 21, 2006 11:02 am

when i request a recursive changeOwnership on a folder i expext itself and all children to be owned by the given user. but if the folder is already owned by the target user the method returns before processing it's children.

proposed solution: wrap lines 150 & 151 into if clause like this:
>        if not recursive:
>            if old==new: return
>            if old is UnownableOwner: return

sry it's not a patch but i think it would be overkill for this simple change ;)
==============================================================