[Checkins] SVN: GenericSetup/trunk/ Security by obscurity isn't very helpful. :) I added a comment on why you should

Lennart Regebro regebro at gmail.com
Tue May 2 08:51:17 EDT 2006


Log message for revision 67832:
  Security by obscurity isn't very helpful. :) I added a comment on why you should 
  import the variables instead of using the values, as the range() trick only obscures 
  it.
  

Changed:
  U   GenericSetup/trunk/interfaces.py
  U   GenericSetup/trunk/utils.py

-=-
Modified: GenericSetup/trunk/interfaces.py
===================================================================
--- GenericSetup/trunk/interfaces.py	2006-05-02 12:33:03 UTC (rev 67831)
+++ GenericSetup/trunk/interfaces.py	2006-05-02 12:51:17 UTC (rev 67832)
@@ -19,7 +19,9 @@
 from zope.schema import Text
 from zope.schema import TextLine
 
-BASE, EXTENSION = range(1, 3)
+# Please note that these values may change. Always import 
+# the values from here instead of using the values directly.
+BASE, EXTENSION = 1, 2
 SKIPPED_FILES = ('CVS', '.svn', '_svn', '_darcs')
 SKIPPED_SUFFIXES = ('~',)
 

Modified: GenericSetup/trunk/utils.py
===================================================================
--- GenericSetup/trunk/utils.py	2006-05-02 12:33:03 UTC (rev 67831)
+++ GenericSetup/trunk/utils.py	2006-05-02 12:51:17 UTC (rev 67832)
@@ -53,7 +53,9 @@
 _wwwdir = os.path.join( _pkgdir, 'www' )
 _xmldir = os.path.join( _pkgdir, 'xml' )
 
-CONVERTER, DEFAULT, KEY = range(3)
+# Please note that these values may change. Always import 
+# the values from here instead of using the values directly.
+CONVERTER, DEFAULT, KEY = 1, 2, 3
 I18NURI = 'http://xml.zope.org/namespaces/i18n'
 
 



More information about the Checkins mailing list