[Checkins] Re: [Zope-Checkins] SVN: Zope/branches/Zope-2_8-branch/ fix #2235 for real now

Chris Withers chris at simplistix.co.uk
Thu Nov 16 02:33:08 EST 2006


Leonardo Rochael Almeida wrote:
> @@ -615,8 +615,8 @@
>      def getobject(self, rid, REQUEST=None):
>          """Return a cataloged object given a 'data_record_id_'
>          """
> -        obj = self.aq_parent.unrestrictedTraverse(self.getpath(rid))
> -        if not obj:
> +        obj = self.aq_parent.unrestrictedTraverse(self.getpath(rid), None)
> +        if obj is None:

Please revert this change. You've changed the semantics of this 
statement and it will now mask errors in traversing to the path.

This is bad...

cheers,

Chris

-- 
Simplistix - Content Management, Zope & Python Consulting
            - http://www.simplistix.co.uk



More information about the Checkins mailing list