[Checkins] SVN: grok/trunk/ldapaddressbook/src/ldapaddressbook/addressbook.py - refactor LDAP configuration data

Christian Theune ct at gocept.com
Sat Oct 21 11:42:00 EDT 2006


Log message for revision 70867:
   - refactor LDAP configuration data
  

Changed:
  U   grok/trunk/ldapaddressbook/src/ldapaddressbook/addressbook.py

-=-
Modified: grok/trunk/ldapaddressbook/src/ldapaddressbook/addressbook.py
===================================================================
--- grok/trunk/ldapaddressbook/src/ldapaddressbook/addressbook.py	2006-10-21 15:38:36 UTC (rev 70866)
+++ grok/trunk/ldapaddressbook/src/ldapaddressbook/addressbook.py	2006-10-21 15:41:59 UTC (rev 70867)
@@ -21,6 +21,12 @@
 import grok
 
 
+LDAP_SERVER = "ldap://ldaphost:389"
+LDAP_LOGIN = "cn=admin,dc=example,dc=com"
+LDAP_PASSWORD = "password"
+LDAP_SEARCH_BASE = "ou=Addresses,dc=example,dc=com"
+
+
 class AddressBook(grok.Model):
 
     @grok.traverse
@@ -33,10 +39,12 @@
     def listContacts(self):
         return get_contact_list()
 
+
 class AddressBookListing(grok.View):
     grok.context(AddressBook)
     grok.name("index")
 
+
 addressbooklisting = grok.PageTemplate("""\
 <html>
 <body>
@@ -47,6 +55,7 @@
 </body>
 </html>""")
 
+
 class Contact(grok.Model):
 
     class fields:
@@ -113,9 +122,9 @@
 # LDAP helper functions
 
 def get_contact_list():
-    l = ldap.initialize("ldap://uter.whq.gocept.com:389")
-    l.simple_bind_s("cn=admin,dc=gocept,dc=com","asdf")
-    results = l.search_s("ou=Addresses,dc=gocept,dc=com", ldap.SCOPE_SUBTREE, "(objectclass=inetOrgPerson)")
+    l = ldap.initialize(LDAP_SERVER)
+    l.simple_bind_s(LDAP_LOGIN, LDAP_PASSWORD)
+    results = l.search_s(LDAP_SEARCH_BASE, ldap.SCOPE_SUBTREE, "(objectclass=inetOrgPerson)")
     if results is None:
         return []
     cnames = [unicode(x[1]['cn'][0], 'utf-8') for x in results]
@@ -123,9 +132,9 @@
     return cnames
 
 def get_contact(cname):
-    l = ldap.initialize("ldap://ldaphost:389")
-    l.simple_bind_s("cn=admin,dc=example,dc=com", "password")
-    results = l.search_s("ou=Addresses,dc=example,dc=com", 
+    l = ldap.initialize(LDAP_SERVER)
+    l.simple_bind_s(LDAP_LOGIN, LDAP_PASSWORD)
+    results = l.search_s(LDAP_SEARCH_BASE,
                          ldap.SCOPE_SUBTREE,
                          "(&(objectclass=inetOrgPerson)(cn=%s))" % cname)
     if results:



More information about the Checkins mailing list