[Checkins] SVN: zc.objectlog/trunk/src/zc/objectlog/log.py add note about problem I noticed

Gary Poster gary at zope.com
Sat Sep 2 16:47:59 EDT 2006


Log message for revision 69940:
  add note about problem I noticed
  

Changed:
  U   zc.objectlog/trunk/src/zc/objectlog/log.py

-=-
Modified: zc.objectlog/trunk/src/zc/objectlog/log.py
===================================================================
--- zc.objectlog/trunk/src/zc/objectlog/log.py	2006-09-02 20:47:08 UTC (rev 69939)
+++ zc.objectlog/trunk/src/zc/objectlog/log.py	2006-09-02 20:47:58 UTC (rev 69940)
@@ -91,6 +91,9 @@
             key = (zope.app.keyreference.interfaces.IKeyReference(o),
                    self.__name__)
             t = getTransactionFromPersistentObject(self) or transaction.get()
+            # the following approach behaves badly in the presence of
+            # savepoints.  TODO: convert to use persistent data structure that
+            # will be rolled back when a savepoint is rolled back.
             for hook, args, kwargs in t.getBeforeCommitHooks():
                 if hook is performDeferredLogs:
                     deferred = args[0]



More information about the Checkins mailing list