[Checkins] SVN: z3c.form/trunk/ - Bug (IE): In Internet Explorer,
when a label for a radio input field is only
Stephan Richter
srichter at cosmos.phy.tufts.edu
Wed Aug 8 09:54:51 EDT 2007
Log message for revision 78702:
- Bug (IE): In Internet Explorer, when a label for a radio input field is only
placed around the text describing the choice, then only the text is
surrounded by a dashed box. IE users reported this to be confusing, thus we
now place the label around the text and the input element so that both are
surrounded by the dashed border. In Firefox and KHTML (Safari) only the
radio button is surrounded all the time.
Changed:
U z3c.form/trunk/CHANGES.txt
U z3c.form/trunk/src/z3c/form/browser/README.txt
U z3c.form/trunk/src/z3c/form/browser/radio.txt
U z3c.form/trunk/src/z3c/form/browser/radio_input.pt
-=-
Modified: z3c.form/trunk/CHANGES.txt
===================================================================
--- z3c.form/trunk/CHANGES.txt 2007-08-08 13:28:15 UTC (rev 78701)
+++ z3c.form/trunk/CHANGES.txt 2007-08-08 13:54:51 UTC (rev 78702)
@@ -42,6 +42,13 @@
- Documentation: While reviewing the ``form.txt`` with some people, several
unclear and incomplete statements were discovered and fixed.
+- Bug (IE): In Internet Explorer, when a label for a radio input field is only
+ placed around the text describing the choice, then only the text is
+ surrounded by a dashed box. IE users reported this to be confusing, thus we
+ now place the label around the text and the input element so that both are
+ surrounded by the dashed border. In Firefox and KHTML (Safari) only the
+ radio button is surrounded all the time.
+
- Bug: When extracting and validating data in the widget manager, invariant
errors were not converted to error view snippets.
Modified: z3c.form/trunk/src/z3c/form/browser/README.txt
===================================================================
--- z3c.form/trunk/src/z3c/form/browser/README.txt 2007-08-08 13:28:15 UTC (rev 78701)
+++ z3c.form/trunk/src/z3c/form/browser/README.txt 2007-08-08 13:54:51 UTC (rev 78702)
@@ -58,8 +58,8 @@
>>> widget = setupWidget(field)
>>> widget.update()
>>> print widget.render()
- <input type="text" id="foo" name="bar" class="text-widget required asciiline-field"
- value="An ASCII line." />
+ <input type="text" id="foo" name="bar"
+ class="text-widget required asciiline-field" value="An ASCII line." />
>>> widget.mode = interfaces.DISPLAY_MODE
>>> print widget.render()
@@ -75,15 +75,16 @@
>>> widget.update()
>>> print widget.render()
<span class="option">
- <input type="radio" id="foo-0" name="bar:list"
- class="radio-widget required bool-field" value="true" checked="checked" />
<label for="foo-0">
+ <input type="radio" id="foo-0" name="bar:list"
+ class="radio-widget required bool-field" value="true"
+ checked="checked" />
<span class="label">yes</span>
</label>
</span><span class="option">
- <input type="radio" id="foo-1" name="bar:list"
- class="radio-widget required bool-field" value="false" />
<label for="foo-1">
+ <input type="radio" id="foo-1" name="bar:list"
+ class="radio-widget required bool-field" value="false" />
<span class="label">no</span>
</label>
</span>
Modified: z3c.form/trunk/src/z3c/form/browser/radio.txt
===================================================================
--- z3c.form/trunk/src/z3c/form/browser/radio.txt 2007-08-08 13:28:15 UTC (rev 78701)
+++ z3c.form/trunk/src/z3c/form/browser/radio.txt 2007-08-08 13:54:51 UTC (rev 78702)
@@ -69,15 +69,15 @@
>>> widget.update()
>>> print widget.render()
<span class="option">
- <input type="radio" id="widget-id-0" name="widget.name:list"
- class="radio-widget" value="true" />
<label for="widget-id-0">
+ <input type="radio" id="widget-id-0" name="widget.name:list"
+ class="radio-widget" value="true" />
<span class="label">yes</span>
</label>
</span><span class="option">
- <input type="radio" id="widget-id-1" name="widget.name:list"
- class="radio-widget" value="false" />
<label for="widget-id-1">
+ <input type="radio" id="widget-id-1" name="widget.name:list"
+ class="radio-widget" value="false" />
<span class="label">no</span>
</label>
</span>
@@ -90,15 +90,15 @@
>>> widget.update()
>>> print widget.render()
<span class="option">
- <input type="radio" id="widget-id-0" name="widget.name:list"
- class="radio-widget" value="true" checked="checked" />
<label for="widget-id-0">
+ <input type="radio" id="widget-id-0" name="widget.name:list"
+ class="radio-widget" value="true" checked="checked" />
<span class="label">yes</span>
</label>
</span><span class="option">
- <input type="radio" id="widget-id-1" name="widget.name:list"
- class="radio-widget" value="false" />
<label for="widget-id-1">
+ <input type="radio" id="widget-id-1" name="widget.name:list"
+ class="radio-widget" value="false" />
<span class="label">no</span>
</label>
</span>
Modified: z3c.form/trunk/src/z3c/form/browser/radio_input.pt
===================================================================
--- z3c.form/trunk/src/z3c/form/browser/radio_input.pt 2007-08-08 13:28:15 UTC (rev 78701)
+++ z3c.form/trunk/src/z3c/form/browser/radio_input.pt 2007-08-08 13:54:51 UTC (rev 78702)
@@ -1,64 +1,64 @@
<span class="option"
tal:repeat="item view/items">
- <input type="radio" id="" name="" class="" alt="" title=""
- tabindex="" disabled="" readonly="" accesskey="" value=""
- checked="checked"
- tal:condition="item/checked"
- tal:attributes="id item/id;
- name item/name;
- value item/value;
- class view/klass;
- title view/title;
- lang view/lang;
- onclick view/onclick;
- ondblclick view/ondblclick;
- onmousedown view/onmousedown;
- onmouseup view/onmouseup;
- onmouseover view/onmouseover;
- onmousemove view/onmousemove;
- onmouseout view/onmouseout;
- onkeypress view/onkeypress;
- onkeydown view/onkeydown;
- onkeyup view/onkeyup;
- disabled view/disabled;
- tabindex view/tabindex;
- onfocus view/onfocus;
- onblur view/onblur;
- onchange view/onchange;
- readonly view/readonly;
- alt view/alt;
- accesskey view/accesskey;
- onselect view/onselect"
- /><input type="radio" id="" name="" class="" alt="" title="" tabindex=""
- disabled="" readonly="" accesskey="" value=""
- tal:condition="not:item/checked"
- tal:attributes="id item/id;
- name item/name;
- value item/value;
- class view/klass;
- title view/title;
- lang view/lang;
- onclick view/onclick;
- ondblclick view/ondblclick;
- onmousedown view/onmousedown;
- onmouseup view/onmouseup;
- onmouseover view/onmouseover;
- onmousemove view/onmousemove;
- onmouseout view/onmouseout;
- onkeypress view/onkeypress;
- onkeydown view/onkeydown;
- onkeyup view/onkeyup;
- disabled view/disabled;
- tabindex view/tabindex;
- onfocus view/onfocus;
- onblur view/onblur;
- onchange view/onchange;
- readonly view/readonly;
- alt view/alt;
- accesskey view/accesskey;
- onselect view/onselect" />
<label for=""
tal:attributes="for item/id">
+ <input type="radio" id="" name="" class="" alt="" title=""
+ tabindex="" disabled="" readonly="" accesskey="" value=""
+ checked="checked"
+ tal:condition="item/checked"
+ tal:attributes="id item/id;
+ name item/name;
+ value item/value;
+ class view/klass;
+ title view/title;
+ lang view/lang;
+ onclick view/onclick;
+ ondblclick view/ondblclick;
+ onmousedown view/onmousedown;
+ onmouseup view/onmouseup;
+ onmouseover view/onmouseover;
+ onmousemove view/onmousemove;
+ onmouseout view/onmouseout;
+ onkeypress view/onkeypress;
+ onkeydown view/onkeydown;
+ onkeyup view/onkeyup;
+ disabled view/disabled;
+ tabindex view/tabindex;
+ onfocus view/onfocus;
+ onblur view/onblur;
+ onchange view/onchange;
+ readonly view/readonly;
+ alt view/alt;
+ accesskey view/accesskey;
+ onselect view/onselect"
+ /><input type="radio" id="" name="" class="" alt="" title="" tabindex=""
+ disabled="" readonly="" accesskey="" value=""
+ tal:condition="not:item/checked"
+ tal:attributes="id item/id;
+ name item/name;
+ value item/value;
+ class view/klass;
+ title view/title;
+ lang view/lang;
+ onclick view/onclick;
+ ondblclick view/ondblclick;
+ onmousedown view/onmousedown;
+ onmouseup view/onmouseup;
+ onmouseover view/onmouseover;
+ onmousemove view/onmousemove;
+ onmouseout view/onmouseout;
+ onkeypress view/onkeypress;
+ onkeydown view/onkeydown;
+ onkeyup view/onkeyup;
+ disabled view/disabled;
+ tabindex view/tabindex;
+ onfocus view/onfocus;
+ onblur view/onblur;
+ onchange view/onchange;
+ readonly view/readonly;
+ alt view/alt;
+ accesskey view/accesskey;
+ onselect view/onselect" />
<span class="label" tal:content="item/label">Label</span>
</label>
</span>
More information about the Checkins
mailing list