[Checkins] SVN: z3c.zalchemy/trunk/src/z3c/zalchemy/datamanager.py accidently stored the engine on a persistent attribute which is obviously not a good idea.

Christian Zagrodnick cz at gocept.com
Fri Aug 10 10:54:42 EDT 2007


Log message for revision 78743:
  accidently stored the engine on a persistent attribute which is obviously not a good idea.

Changed:
  U   z3c.zalchemy/trunk/src/z3c/zalchemy/datamanager.py

-=-
Modified: z3c.zalchemy/trunk/src/z3c/zalchemy/datamanager.py
===================================================================
--- z3c.zalchemy/trunk/src/z3c/zalchemy/datamanager.py	2007-08-10 09:13:41 UTC (rev 78742)
+++ z3c.zalchemy/trunk/src/z3c/zalchemy/datamanager.py	2007-08-10 14:54:41 UTC (rev 78743)
@@ -44,21 +44,21 @@
         self.kw.update(kwargs)
 
     def getEngine(self):
-        engine = getattr(self,'engine',None)
+        engine = getattr(self, '_v_engine', None)
         if engine:
             return engine
         # create_engine consumes the keywords, so better to make a copy first
         kw = {}
         kw.update(self.kw)
         # create a new engine and configure it thread local
-        self.engine = sqlalchemy.create_engine(
+        self._v_engine = sqlalchemy.create_engine(
             self.dsn, echo=self.echo, encoding=self.encoding,
             convert_unicode=self.convert_unicode,
             strategy='threadlocal', **kw)
-        return self.engine
+        return self._v_engine
 
     def _resetEngine(self):
-        engine = getattr(self, 'engine', None)
+        engine = getattr(self, '_v_engine', None)
         if engine is not None:
             engine.dispose()
             self.engine = None



More information about the Checkins mailing list