[Checkins] SVN: zope.security/trunk/ Fixed buglet: system_user had an ugly id.

Jim Fulton jim at zope.com
Tue Aug 14 14:13:27 EDT 2007


Log message for revision 78817:
  Fixed buglet: system_user had an ugly id.
  
  Added missing test.
  

Changed:
  U   zope.security/trunk/CHANGES.txt
  U   zope.security/trunk/setup.py
  U   zope.security/trunk/src/zope/security/_definitions.py
  U   zope.security/trunk/src/zope/security/tests/test_management.py

-=-
Modified: zope.security/trunk/CHANGES.txt
===================================================================
--- zope.security/trunk/CHANGES.txt	2007-08-14 18:13:12 UTC (rev 78816)
+++ zope.security/trunk/CHANGES.txt	2007-08-14 18:13:27 UTC (rev 78817)
@@ -7,6 +7,14 @@
 Bugs fixed:
 -----------
 
+- zope.security.management.system_user had an ugly/brittle id.
+
+3.4.0b3 - 2007/08/14
+--------------------
+
+Bugs fixed:
+-----------
+
 - zope.security.management.system_user wasn't a valid principal
   (didn't provide IPrincipal).
 

Modified: zope.security/trunk/setup.py
===================================================================
--- zope.security/trunk/setup.py	2007-08-14 18:13:12 UTC (rev 78816)
+++ zope.security/trunk/setup.py	2007-08-14 18:13:27 UTC (rev 78817)
@@ -21,7 +21,7 @@
 from setuptools import setup, find_packages, Extension
 
 setup(name='zope.security',
-      version = '3.4.0b3',
+      version = '3.4.0b4',
       url='http://svn.zope.org/zope.security',
       license='ZPL 2.1',
       description='Zope3 Security Architecture',

Modified: zope.security/trunk/src/zope/security/_definitions.py
===================================================================
--- zope.security/trunk/src/zope/security/_definitions.py	2007-08-14 18:13:12 UTC (rev 78816)
+++ zope.security/trunk/src/zope/security/_definitions.py	2007-08-14 18:13:27 UTC (rev 78817)
@@ -24,6 +24,6 @@
 
 class system_user(object):
     zope.interface.classProvides(zope.security.interfaces.IPrincipal)
-    id = __name__ + u'.system_user'
+    id = u'zope.security.management.system_user'
     title = u'Special System User that typically has all permissions'
     description = u''

Modified: zope.security/trunk/src/zope/security/tests/test_management.py
===================================================================
--- zope.security/trunk/src/zope/security/tests/test_management.py	2007-08-14 18:13:12 UTC (rev 78816)
+++ zope.security/trunk/src/zope/security/tests/test_management.py	2007-08-14 18:13:27 UTC (rev 78817)
@@ -114,7 +114,15 @@
         self.assertEquals(checkPermission(None, obj), True)
         self.assertEquals(checkPermission(CheckerPublic, obj), True)
 
+    def test_system_user(self):
+        from zope.security.management import system_user
+        self.assertEquals(system_user.id,
+                          u'zope.security.management.system_user')
 
+        self.assert_(system_user.title)
+        for name in 'id', 'title', 'description':
+            self.assert_(isinstance(getattr(system_user, name), unicode))
+
 def test_suite():
     loader = unittest.TestLoader()
     return loader.loadTestsFromTestCase(Test)



More information about the Checkins mailing list