[Checkins] SVN: zope.traversing/trunk/ Backed out the controversial XML-RPC layer support.

Christian Theune ct at gocept.com
Fri Dec 28 08:07:29 EST 2007


Log message for revision 82482:
  Backed out the controversial XML-RPC layer support.
  
  Fixed version to comply with guides.
  
  

Changed:
  U   zope.traversing/trunk/CHANGES.txt
  U   zope.traversing/trunk/setup.py
  U   zope.traversing/trunk/src/zope/traversing/configure.zcml
  U   zope.traversing/trunk/src/zope/traversing/namespace.py
  U   zope.traversing/trunk/src/zope/traversing/tests/test_traverser.py

-=-
Modified: zope.traversing/trunk/CHANGES.txt
===================================================================
--- zope.traversing/trunk/CHANGES.txt	2007-12-28 13:02:20 UTC (rev 82481)
+++ zope.traversing/trunk/CHANGES.txt	2007-12-28 13:07:29 UTC (rev 82482)
@@ -2,8 +2,13 @@
 Changes
 =======
 
+After 3.5.0a2 (unreleased)
+--------------------------
+
+- backed out the controversial `++skin++` traverser for XML-RPC.
+
 3.5.0a2 (2007-11-28)
-====================
+--------------------
 
 - ported 3.4.1a1 to trunk
   - Do not use unicode strings to set the application server in the virtual

Modified: zope.traversing/trunk/setup.py
===================================================================
--- zope.traversing/trunk/setup.py	2007-12-28 13:02:20 UTC (rev 82481)
+++ zope.traversing/trunk/setup.py	2007-12-28 13:07:29 UTC (rev 82482)
@@ -22,7 +22,7 @@
                     open('CHANGES.txt').read())
 
 setup(name='zope.traversing',
-      version = '3.5.0a3',
+      version = '3.5dev',
       url='http://pypi.python.org/pypi/zope.traversing',
       license='ZPL 2.1',
       author='Zope Corporation and Contributors',
@@ -45,7 +45,7 @@
                         'zope.i18nmessageid',
                         'zope.interface',
                         'zope.proxy',
-                        'zope.publisher>=3.5.0a1.dev-r78727',
+                        'zope.publisher',
                         'zope.security',
                         ],
       include_package_data = True,

Modified: zope.traversing/trunk/src/zope/traversing/configure.zcml
===================================================================
--- zope.traversing/trunk/src/zope/traversing/configure.zcml	2007-12-28 13:02:20 UTC (rev 82481)
+++ zope.traversing/trunk/src/zope/traversing/configure.zcml	2007-12-28 13:07:29 UTC (rev 82482)
@@ -95,18 +95,12 @@
     />
 
 <view
-    name="skin" type="zope.publisher.interfaces.browser.IBrowserRequest"
+    name="skin" type="*"
     provides="zope.traversing.interfaces.ITraversable" for="*"
     factory="zope.traversing.namespace.skin"
     />
 
 <view
-    name="skin" type="zope.publisher.interfaces.xmlrpc.IXMLRPCRequest"
-    provides="zope.traversing.interfaces.ITraversable" for="*"
-    factory="zope.traversing.namespace.xmlrpc_skin"
-    />
-
-<view
     name="vh" type="*"
     provides="zope.traversing.interfaces.ITraversable" for="*"
     factory="zope.traversing.namespace.vh"

Modified: zope.traversing/trunk/src/zope/traversing/namespace.py
===================================================================
--- zope.traversing/trunk/src/zope/traversing/namespace.py	2007-12-28 13:02:20 UTC (rev 82481)
+++ zope.traversing/trunk/src/zope/traversing/namespace.py	2007-12-28 13:07:29 UTC (rev 82482)
@@ -25,7 +25,6 @@
 from zope.component.interfaces import ComponentLookupError
 from zope.interface import providedBy, directlyProvides, directlyProvidedBy
 from zope.publisher.interfaces.browser import IBrowserSkinType
-from zope.publisher.interfaces.xmlrpc import IXMLRPCSkinType
 from zope.publisher.browser import applySkin
 from zope.security.proxy import removeSecurityProxy
 from zope.traversing.interfaces import ITraversable, IPathAdapter
@@ -367,23 +366,15 @@
 
 class skin(view):
 
-    skin_type = IBrowserSkinType
-
     def traverse(self, name, ignored):
         self.request.shiftNameToApplication()
         try:
-            skin = zope.component.getUtility(self.skin_type, name)
+            skin = zope.component.getUtility(IBrowserSkinType, name)
         except ComponentLookupError:
             raise TraversalError("++skin++%s" % name)
         applySkin(self.request, skin)
         return self.context
 
-
-class xmlrpc_skin(skin):
-
-    skin_type = IXMLRPCSkinType
-
-
 class vh(view):
 
     def traverse(self, name, ignored):

Modified: zope.traversing/trunk/src/zope/traversing/tests/test_traverser.py
===================================================================
--- zope.traversing/trunk/src/zope/traversing/tests/test_traverser.py	2007-12-28 13:02:20 UTC (rev 82481)
+++ zope.traversing/trunk/src/zope/traversing/tests/test_traverser.py	2007-12-28 13:07:29 UTC (rev 82482)
@@ -18,7 +18,7 @@
 import unittest
 
 import zope.component
-from zope.interface import directlyProvides, implementedBy, directlyProvidedBy
+from zope.interface import directlyProvides, implementedBy
 from zope.interface.verify import verifyClass
 from zope.location.traversing import LocationPhysicallyLocatable
 from zope.security.interfaces import Unauthorized



More information about the Checkins mailing list