[Checkins] SVN: z3c.vcsync/trunk/src/z3c/vcsync/vc.py Cannot rely on 'obj.__parent__' to work if obj is removed from its container.

Martijn Faassen faassen at infrae.com
Wed Jul 4 20:07:57 EDT 2007


Log message for revision 77440:
  Cannot rely on 'obj.__parent__' to work if obj is removed from its container.
  

Changed:
  U   z3c.vcsync/trunk/src/z3c/vcsync/vc.py

-=-
Modified: z3c.vcsync/trunk/src/z3c/vcsync/vc.py
===================================================================
--- z3c.vcsync/trunk/src/z3c/vcsync/vc.py	2007-07-04 23:01:57 UTC (rev 77439)
+++ z3c.vcsync/trunk/src/z3c/vcsync/vc.py	2007-07-05 00:07:57 UTC (rev 77440)
@@ -130,9 +130,11 @@
         for modified_path in self.modified():
             obj = resolve(root, self.path, modified_path)
             factory = getUtility(IVcFactory, name=modified_path.ext)
-            del obj.__parent__[obj.__name__]
-            obj.__parent__[obj.__name__] = factory(self, modified_path)
-                
+            container = obj.__parent__
+            name = obj.__name__
+            del container[name]
+            container[name] = factory(self, modified_path)
+
     def up(self):
         raise NotImplementedError
 



More information about the Checkins mailing list