[Checkins] SVN: zope.app.undo/branches/nikhil_n-py25/src/zope/app/undo/__init__.py made zope.app.undo work with Python 2.5

Benji York benji at zope.com
Sat Jul 7 09:22:19 EDT 2007


Christian Theune wrote:
> I'd at least split the code into two parts: determine whether to use
> __cmp__ or __eq__ and then apply the test.

Another thing: It looks like the new code expects 1 as the result of 
__cmp__ and __eq__ to mean the same thing, but they don't.  __cmp__ 
returns 1 for self is greater than other, but __eq__ returns 1 if they 
are equal.
-- 
Benji York
Senior Software Engineer
Zope Corporation


More information about the Checkins mailing list