[Checkins] SVN: z3c.conditionalviews/trunk/ Fix time zone issue.

Michael Kerrin michael.kerrin at openapp.ie
Tue Jul 10 08:38:59 EDT 2007


Log message for revision 77678:
  Fix time zone issue.
  

Changed:
  A   z3c.conditionalviews/trunk/CHANGES.txt
  U   z3c.conditionalviews/trunk/setup.py
  U   z3c.conditionalviews/trunk/src/z3c/conditionalviews/lastmodification.py

-=-
Added: z3c.conditionalviews/trunk/CHANGES.txt
===================================================================
--- z3c.conditionalviews/trunk/CHANGES.txt	                        (rev 0)
+++ z3c.conditionalviews/trunk/CHANGES.txt	2007-07-10 12:38:58 UTC (rev 77678)
@@ -0,0 +1,13 @@
+===============================
+Changes in z3c.conditionalviews
+===============================
+
+1.0b
+====
+
+- Fixed time zone issue in processing `If-Modified` protocol.
+
+0.9
+===
+
+- Initial release.

Modified: z3c.conditionalviews/trunk/setup.py
===================================================================
--- z3c.conditionalviews/trunk/setup.py	2007-07-10 11:29:49 UTC (rev 77677)
+++ z3c.conditionalviews/trunk/setup.py	2007-07-10 12:38:58 UTC (rev 77678)
@@ -2,12 +2,15 @@
 
 setup(
     name = "z3c.conditionalviews",
-    version = "0.9",
+    version = "1.0b",
     author = "Michael Kerrin",
     author_email = "michael.kerrin at openapp.ie",
     url = "http://svn.zope.org/z3c.conditionalviews/",
     description = "Validation mechanism for conditional HTTP requests.",
-    long_description = open("README.txt").read(),
+    long_description = (
+        open("README.txt").read() +
+        "\n\n" +
+        open("CHANGES.txt").read()),
     license = "ZPL 2.1",
 
     packages = find_packages("src"),

Modified: z3c.conditionalviews/trunk/src/z3c/conditionalviews/lastmodification.py
===================================================================
--- z3c.conditionalviews/trunk/src/z3c/conditionalviews/lastmodification.py	2007-07-10 11:29:49 UTC (rev 77677)
+++ z3c.conditionalviews/trunk/src/z3c/conditionalviews/lastmodification.py	2007-07-10 12:38:58 UTC (rev 77678)
@@ -10,7 +10,6 @@
 # FOR A PARTICULAR PURPOSE.
 ##############################################################################
 
-import time
 import calendar
 import zope.component
 import zope.datetime
@@ -28,7 +27,8 @@
       >>> from zope.publisher.browser import BrowserView
 
       >>> def format(dt):
-      ...    return zope.datetime.rfc1123_date(time.mktime(dt.utctimetuple()))
+      ...    return zope.datetime.rfc1123_date(
+      ...        calendar.timegm(dt.utctimetuple()))
 
       >>> lmt = datetime.datetime(2007, 1, 6, 13, 42, 12,
       ...    tzinfo = zope.datetime.tzinfo(60))
@@ -269,7 +269,7 @@
         headervalue = request.getHeader(header, None)
         if headervalue is not None:
             # current last modification time for this view
-            last_modification_time = long(time.mktime(mtime.utctimetuple()))
+            last_modification_time = long(calendar.timegm(mtime.utctimetuple()))
             try:
                 headervalue = long(zope.datetime.time(
                     headervalue.split(";", 1)[0]))



More information about the Checkins mailing list