[Checkins] SVN: grok/trunk/src/grok/ I found that using a label tag caused the checkbox to be selected when clicking the link (firefox). I have changed the template and ftest to remove the label tag.

Darryl Cousins darryl at darrylcousins.net.nz
Sun Mar 25 04:28:33 EDT 2007


Log message for revision 73540:
  I found that using a label tag caused the checkbox to be selected when clicking the link (firefox). I have changed the template and ftest to remove the label tag.

Changed:
  U   grok/trunk/src/grok/admin/view_templates/index.pt
  U   grok/trunk/src/grok/ftests/admin/admin.py

-=-
Modified: grok/trunk/src/grok/admin/view_templates/index.pt
===================================================================
--- grok/trunk/src/grok/admin/view_templates/index.pt	2007-03-25 08:27:56 UTC (rev 73539)
+++ grok/trunk/src/grok/admin/view_templates/index.pt	2007-03-25 08:28:32 UTC (rev 73540)
@@ -13,14 +13,12 @@
 
     <ul>
       <li tal:repeat="app apps">
-      <label>
         <input type="checkbox" tal:attributes="value app/__name__;
                                                name string:items" />
         <a tal:attributes="href string:${context/@@absolute_url}/${app/__name__}">
           <span tal:replace="app/__name__"/>
           (<span tal:replace="app/__class__/__name__"/>)
         </a>
-        </label>
       </li>
     </ul>
 

Modified: grok/trunk/src/grok/ftests/admin/admin.py
===================================================================
--- grok/trunk/src/grok/ftests/admin/admin.py	2007-03-25 08:27:56 UTC (rev 73539)
+++ grok/trunk/src/grok/ftests/admin/admin.py	2007-03-25 08:28:32 UTC (rev 73540)
@@ -18,13 +18,13 @@
   >>> print browser.contents
   <html>
   ...
-      <label>
+      <li>
         <input type="checkbox" name="items" value="my-mammoth-manager" />
         <a href="http://localhost/my-mammoth-manager">
           my-mammoth-manager
           (MammothManager)
         </a>
-      </label>
+      </li>
   ...
   >>> browser.getLink('my-mammoth-manager').click()
   >>> print browser.contents
@@ -38,7 +38,8 @@
   ...
   ...<legend>Installed applications</legend>
   ...
-  >>> browser.getControl('my-mammoth-manager (MammothManager)').selected = True
+  >>> ctrl = browser.getControl(name='items')
+  >>> ctrl.getControl(value='my-mammoth-manager').selected = True
   >>> browser.getControl('Delete Selected').click()
   >>> print browser.contents
   <html>



More information about the Checkins mailing list