[Checkins] SVN: z3c.reference/trunk/src/z3c/reference/browser/ Simplify subclassing

Juergen Kartnaller juergen at kartnaller.at
Wed Nov 7 03:44:55 EST 2007


Log message for revision 81576:
  Simplify subclassing

Changed:
  U   z3c.reference/trunk/src/z3c/reference/browser/configure.zcml
  U   z3c.reference/trunk/src/z3c/reference/browser/views.py

-=-
Modified: z3c.reference/trunk/src/z3c/reference/browser/configure.zcml
===================================================================
--- z3c.reference/trunk/src/z3c/reference/browser/configure.zcml	2007-11-07 07:10:14 UTC (rev 81575)
+++ z3c.reference/trunk/src/z3c/reference/browser/configure.zcml	2007-11-07 08:44:54 UTC (rev 81576)
@@ -44,9 +44,10 @@
                    require="z3c.javascript.jquery
                             z3c.javascript.swfobject
                             z3c.reference.base">
-      <directory source="resources"
-          include="reference.editor.js popupwindow.css"
-          />
+     <directory
+        source="resources"
+        include="reference.editor.js popupwindow.css"
+        />
   </resourceLibrary>
 
 

Modified: z3c.reference/trunk/src/z3c/reference/browser/views.py
===================================================================
--- z3c.reference/trunk/src/z3c/reference/browser/views.py	2007-11-07 07:10:14 UTC (rev 81575)
+++ z3c.reference/trunk/src/z3c/reference/browser/views.py	2007-11-07 08:44:54 UTC (rev 81576)
@@ -38,7 +38,7 @@
 noImage = '/@@/z3c.reference.resources/noimage.jpg'
 
 
-class ViewReferenceEditor(object):
+class ViewReferenceEditorMixin(object):
     """View reference editor offering search and edit form setup.
     The following objects are used:
     context = view reference
@@ -49,13 +49,18 @@
     targetStr = u''
     formdata = u''
 
-    def __call__(self):
-        resourcelibrary.need('z3c.reference.popup')
-        """Setup JS variables."""
+    def setUpJSVariables(self):
         self.name = self.request.get('name', u'')
         self.settingNameStr = self.request.get('settingName', u'')
         self.targetStr = self.request.get('target', u'')
         self.formdata = self.request.get('formdata', u'')
+
+
+class ViewReferenceEditor(ViewReferenceEditorMixin):
+
+    def __call__(self):
+        resourcelibrary.need('z3c.reference.popup')
+        self.setUpJSVariables()
         return super(ViewReferenceEditor, self).__call__()
 
 



More information about the Checkins mailing list