[Checkins] SVN: zope.traversing/branches/3.4/ Do not use unicode strings to set the application server in the virtual host

Juergen Kartnaller juergen at kartnaller.at
Tue Nov 13 08:07:08 EST 2007


Log message for revision 81818:
  Do not use unicode strings to set the application server in the virtual host
  namespace. This caused absolute_url to create unicode URL's.
  

Changed:
  U   zope.traversing/branches/3.4/CHANGES.txt
  U   zope.traversing/branches/3.4/src/zope/traversing/namespace.py
  U   zope.traversing/branches/3.4/src/zope/traversing/tests/test_vh.py

-=-
Modified: zope.traversing/branches/3.4/CHANGES.txt
===================================================================
--- zope.traversing/branches/3.4/CHANGES.txt	2007-11-13 10:31:53 UTC (rev 81817)
+++ zope.traversing/branches/3.4/CHANGES.txt	2007-11-13 13:07:08 UTC (rev 81818)
@@ -6,6 +6,14 @@
 
 ...
 
+
+3.4.1a1 (2007-11-13)
+--------------------
+
+- do not use unicode strings to set the application server in the virtual host
+  namespace. This caused absolute_url to create unicode URL's.
+
+
 3.4.0 (2007-09-29)
 ------------------
 

Modified: zope.traversing/branches/3.4/src/zope/traversing/namespace.py
===================================================================
--- zope.traversing/branches/3.4/src/zope/traversing/namespace.py	2007-11-13 10:31:53 UTC (rev 81817)
+++ zope.traversing/branches/3.4/src/zope/traversing/namespace.py	2007-11-13 13:07:08 UTC (rev 81818)
@@ -381,6 +381,7 @@
         traversal_stack = request.getTraversalStack()
         app_names = []
 
+        name = name.encode('utf8')
         if name:
             try:
                 proto, host, port = name.split(":")

Modified: zope.traversing/branches/3.4/src/zope/traversing/tests/test_vh.py
===================================================================
--- zope.traversing/branches/3.4/src/zope/traversing/tests/test_vh.py	2007-11-13 10:31:53 UTC (rev 81817)
+++ zope.traversing/branches/3.4/src/zope/traversing/tests/test_vh.py	2007-11-13 13:07:08 UTC (rev 81818)
@@ -77,6 +77,17 @@
 
         self.assertEqual(request._app_server, 'http://www.fubarco.com:80')
 
+
+    def test_unicode_vh_host(self):
+        from zope.traversing.namespace import vh
+
+        request = TestRequest(['folder1'], ['folder1_1', '++'])
+        ob = object()
+
+        result = vh(ob, request).traverse(u'http:www.fubarco.com:80', ())
+        assert(isinstance(request._app_server, str))
+
+
 def test_suite():
     suite = unittest.TestSuite()
     suite.addTest(unittest.makeSuite(TestVHNamespace))



More information about the Checkins mailing list