[Checkins] SVN: zope.app.keyreference/trunk/ performance fix for KeyReferenceToPersistent.

Alex Smith asmith at zope.com
Thu Aug 14 17:28:40 EDT 2008


Log message for revision 89844:
  
  performance fix for KeyReferenceToPersistent.
  

Changed:
  U   zope.app.keyreference/trunk/CHANGES.txt
  U   zope.app.keyreference/trunk/setup.py
  U   zope.app.keyreference/trunk/src/zope/app/keyreference/persistent.py

-=-
Modified: zope.app.keyreference/trunk/CHANGES.txt
===================================================================
--- zope.app.keyreference/trunk/CHANGES.txt	2008-08-14 20:18:50 UTC (rev 89843)
+++ zope.app.keyreference/trunk/CHANGES.txt	2008-08-14 21:28:39 UTC (rev 89844)
@@ -5,6 +5,9 @@
 3.5.0 (unreleased)
 ------------------
 
+- Performance related change to
+  `zope.app.keyreference.persistent.KeyReferenceToPersistent.__cmp__`.
+
 - Added support for new `ZODB.ConflictResolution.PersistentReference` behavior
   to persistent key references so that they can now, in many cases, allow
   conflict resolution when they are used as keys or set members in ZODB

Modified: zope.app.keyreference/trunk/setup.py
===================================================================
--- zope.app.keyreference/trunk/setup.py	2008-08-14 20:18:50 UTC (rev 89843)
+++ zope.app.keyreference/trunk/setup.py	2008-08-14 21:28:39 UTC (rev 89844)
@@ -22,7 +22,7 @@
     return open(os.path.join(os.path.dirname(__file__), *rnames)).read()
 
 setup(name = 'zope.app.keyreference',
-      version = '3.5.0b2',
+      version = '3.5.0b3',
       author='Zope Corporation and Contributors',
       author_email='zope3-dev at zope.org',
       description='Key References',

Modified: zope.app.keyreference/trunk/src/zope/app/keyreference/persistent.py
===================================================================
--- zope.app.keyreference/trunk/src/zope/app/keyreference/persistent.py	2008-08-14 20:18:50 UTC (rev 89843)
+++ zope.app.keyreference/trunk/src/zope/app/keyreference/persistent.py	2008-08-14 21:28:39 UTC (rev 89844)
@@ -61,7 +61,7 @@
 
     def __cmp__(self, other):
         if self.key_type_id == other.key_type_id:
-            if isinstance(self.object, PersistentReference):
+            if type(self.object) is PersistentReference:
                 # we are doing conflict resolution.
                 assert isinstance(other.object, PersistentReference), (
                     'other object claims to be '



More information about the Checkins mailing list