[Checkins] SVN: zope.app.keyreference/trunk/ performance fix for KeyReferenceToPersistent.

Philipp von Weitershausen philipp at weitershausen.de
Fri Aug 15 01:34:32 EDT 2008


Gary Poster wrote:
> On Aug 14, 2008, at 5:34 PM, Alexander J Smith wrote:
> 
>> Yes, it will.  Don't do that.
> 
> Heh.
> 
> Wichert, IMO this class is largely an implementation detail of the  
> current ZODB conflict resolution code.  Subclassing it is, as I said  
> to folks here, "inconceivable".

Makes sense. It would've been nice if the change had come with a 
comment, it helps understand the reasoning behind it, especially to 
somebody who's not reading the commit list or is reading the code 6 
months from now. I've added a one comment now.



More information about the Checkins mailing list