[Checkins] SVN: z3c.securitytool/trunk/src/z3c/securitytool/securitytool.py Adding Comments

Daniel Blackburn blackburnd at gmail.com
Thu Feb 7 13:56:27 EST 2008


Log message for revision 83646:
  Adding Comments

Changed:
  U   z3c.securitytool/trunk/src/z3c/securitytool/securitytool.py

-=-
Modified: z3c.securitytool/trunk/src/z3c/securitytool/securitytool.py
===================================================================
--- z3c.securitytool/trunk/src/z3c/securitytool/securitytool.py	2008-02-07 18:51:00 UTC (rev 83645)
+++ z3c.securitytool/trunk/src/z3c/securitytool/securitytool.py	2008-02-07 18:56:27 UTC (rev 83646)
@@ -192,7 +192,6 @@
 
         prinPermSettings = {'permissions': [],
                             'roles': {},
-                            'deniedRoles': {},
                             'groups': {}}
         principals = zapi.principals()
 
@@ -228,12 +227,13 @@
                     mapping = {'permission': permission,
                                'setting': _setting}
 
+                    # We only want to see the role if we are granted
+                    # the allow permission for it
+                    # TODO have an else clause and show denied roles as
+                    # well
                     if prinRoles.get('setting','') == Allow:
                         perms = prinPermSettings['roles'].setdefault(
                             role, [])
-                    else:
-                        perms = prinPermSettings['deniedRoles'].setdefault(
-                            role, [])
 
 
                     if not mapping in perms:



More information about the Checkins mailing list