[Checkins] SVN: z3c.breadcrumb/trunk/ Fix the IBreadcrumbs interface to match actual implementation and doctest.

Marius Gedminas marius at pov.lt
Fri Feb 8 14:05:21 EST 2008


Log message for revision 83669:
  Fix the IBreadcrumbs interface to match actual implementation and doctest.
  
  Add a test that uses verifyObject to ensure such mismatches do not recur.
  
  

Changed:
  U   z3c.breadcrumb/trunk/CHANGES.txt
  U   z3c.breadcrumb/trunk/src/z3c/breadcrumb/interfaces.py
  U   z3c.breadcrumb/trunk/src/z3c/breadcrumb/tests.py

-=-
Modified: z3c.breadcrumb/trunk/CHANGES.txt
===================================================================
--- z3c.breadcrumb/trunk/CHANGES.txt	2008-02-08 14:13:04 UTC (rev 83668)
+++ z3c.breadcrumb/trunk/CHANGES.txt	2008-02-08 19:05:20 UTC (rev 83669)
@@ -2,6 +2,12 @@
 CHANGES
 =======
 
+unreleased (2008-02-08)
+----------------------
+
+- Bug: Fixed ``IBreadcrumbs`` to match implementation.
+
+
 1.0.2 (2008-01-23)
 ------------------
 

Modified: z3c.breadcrumb/trunk/src/z3c/breadcrumb/interfaces.py
===================================================================
--- z3c.breadcrumb/trunk/src/z3c/breadcrumb/interfaces.py	2008-02-08 14:13:04 UTC (rev 83668)
+++ z3c.breadcrumb/trunk/src/z3c/breadcrumb/interfaces.py	2008-02-08 19:05:20 UTC (rev 83669)
@@ -27,7 +27,7 @@
     information from each breadcrumb name.
     """
 
-    breadcrumbs = zope.interface.Attribute('An iteratable of all breadcrumbs.')
+    crumbs = zope.interface.Attribute('An iteratable of all breadcrumbs.')
 
 
 class IBreadcrumb(zope.interface.Interface):

Modified: z3c.breadcrumb/trunk/src/z3c/breadcrumb/tests.py
===================================================================
--- z3c.breadcrumb/trunk/src/z3c/breadcrumb/tests.py	2008-02-08 14:13:04 UTC (rev 83668)
+++ z3c.breadcrumb/trunk/src/z3c/breadcrumb/tests.py	2008-02-08 19:05:20 UTC (rev 83669)
@@ -19,8 +19,20 @@
 import unittest
 from zope.testing import doctest
 from zope.app.testing import placelesssetup, setup
+from zope.interface.verify import verifyObject
 
 
+def doctest_Breadcrumbs_interface():
+    """Test that Breadcrumbs matches the interface
+
+        >>> from z3c.breadcrumb import browser, interfaces
+        >>> breadcrumbs = browser.Breadcrumbs(None, None)
+        >>> verifyObject(interfaces.IBreadcrumbs, breadcrumbs)
+        True
+
+    """
+
+
 def setUp(test):
     site = setup.placefulSetUp(site=True)
     test.globs['rootFolder'] = site
@@ -30,9 +42,10 @@
 
 
 def test_suite():
-    return unittest.TestSuite((
+    return unittest.TestSuite([
             doctest.DocFileSuite(
                 'README.txt',
                 setUp=setUp, tearDown=tearDown,
                 optionflags=doctest.NORMALIZE_WHITESPACE|doctest.ELLIPSIS),
-            ))
+            doctest.DocTestSuite(),
+            ])



More information about the Checkins mailing list