[Checkins] SVN: z3c.coverage/trunk/src/z3c/coverage/coveragereport.py Refactoring: move filter_fn to top level, add doctest.

Marius Gedminas marius at pov.lt
Thu Feb 21 14:30:37 EST 2008


Log message for revision 84120:
  Refactoring: move filter_fn to top level, add doctest.
  
  

Changed:
  U   z3c.coverage/trunk/src/z3c/coverage/coveragereport.py

-=-
Modified: z3c.coverage/trunk/src/z3c/coverage/coveragereport.py
===================================================================
--- z3c.coverage/trunk/src/z3c/coverage/coveragereport.py	2008-02-21 19:30:02 UTC (rev 84119)
+++ z3c.coverage/trunk/src/z3c/coverage/coveragereport.py	2008-02-21 19:30:36 UTC (rev 84120)
@@ -375,13 +375,31 @@
         os.mkdir(report_path)
 
 
+def filter_fn(filename):
+    """Filter interesting coverage files.
+    
+        >>> filter_fn('z3c.coverage.__init__.cover')
+        True
+        >>> filter_fn('z3c.coverage.tests.cover')
+        False
+        >>> filter_fn('z3c.coverage.tests.test_foo.cover')
+        False
+        >>> filter_fn('z3c.coverage.ftests.test_bar.cover')
+        False
+        >>> filter_fn('something-unrelated.txt')
+        False
+        >>> filter_fn('<doctest something-useless.cover')
+        False
+
+    """
+    return (filename.endswith('.cover') and
+            'test' not in filename and
+            not filename.startswith('<'))
+
+
 def make_coverage_reports(path, report_path):
     """Convert reports from ``path`` into HTML files in ``report_path``."""
     create_report_path(report_path)
-    def filter_fn(filename):
-        return (filename.endswith('.cover') and
-                'test' not in filename and
-                not filename.startswith('<'))
     filelist = get_file_list(path, filter_fn)
     tree = create_tree(filelist, path)
     rev = get_svn_revision(os.path.join(path, os.path.pardir))



More information about the Checkins mailing list