[Checkins] SVN: Products.CMFDefault/trunk/Products/CMFDefault/ - fixed indexing of 'in_reply_to'

Yvo Schubbe y.2008 at wcm-solutions.de
Fri Jan 11 16:04:17 EST 2008


Log message for revision 82818:
  - fixed indexing of 'in_reply_to'

Changed:
  U   Products.CMFDefault/trunk/Products/CMFDefault/DiscussionItem.py
  U   Products.CMFDefault/trunk/Products/CMFDefault/tests/test_Discussions.py

-=-
Modified: Products.CMFDefault/trunk/Products/CMFDefault/DiscussionItem.py
===================================================================
--- Products.CMFDefault/trunk/Products/CMFDefault/DiscussionItem.py	2008-01-11 21:02:59 UTC (rev 82817)
+++ Products.CMFDefault/trunk/Products/CMFDefault/DiscussionItem.py	2008-01-11 21:04:16 UTC (rev 82818)
@@ -253,9 +253,9 @@
         item.setFormat(text_format)
         item._edit(text)
         item.addCreator(Creator)
+        item.setReplyTo(self._getDiscussable())
+
         item.indexObject()
-
-        item.setReplyTo( self._getDiscussable() )
         item.notifyWorkflowCreated()
 
         return id

Modified: Products.CMFDefault/trunk/Products/CMFDefault/tests/test_Discussions.py
===================================================================
--- Products.CMFDefault/trunk/Products/CMFDefault/tests/test_Discussions.py	2008-01-11 21:02:59 UTC (rev 82817)
+++ Products.CMFDefault/trunk/Products/CMFDefault/tests/test_Discussions.py	2008-01-11 21:04:16 UTC (rev 82818)
@@ -171,6 +171,7 @@
 
     def test_itemCataloguing( self ):
         ctool = self.site._setObject( 'portal_catalog', CatalogTool() )
+        ctool.addColumn('in_reply_to')
         dtool = self.site.portal_discussion
         catalog = ctool._catalog
         test = self._makeDummyContent('test', catalog=1)
@@ -191,6 +192,10 @@
                               '/bar/site/test/talkback/%s' % reply.getId() ) )
 
         reply1 = talkback.getReplies()[0]
+        path1 = '/'.join(reply1.getPhysicalPath())
+        self.assertEqual( ctool.getMetadataForUID(path1),
+                          {'in_reply_to': None} )
+
         talkback1 = dtool.getDiscussionFor(reply1)
         talkback1.createReply( title='test2'
                              , text='blah2'
@@ -204,6 +209,11 @@
             self.failUnless( has_path( catalog,
                               '/bar/site/test/talkback/%s' % reply.getId() ) )
 
+        reply2 = talkback1.getReplies()[0]
+        path2 = '/'.join(reply2.getPhysicalPath())
+        self.assertEqual( ctool.getMetadataForUID(path2),
+                          {'in_reply_to': reply1.getId()} )
+
     def test_itemWorkflowNotification(self):
         from Products.CMFDefault.DiscussionItem import DiscussionItem
 



More information about the Checkins mailing list