[Checkins] Re: SVN: zope.testing/branches/3.5/ Launchpad #242851: applied patch for package normalization

Andreas Jung lists at zopyx.com
Tue Jul 8 02:06:59 EDT 2008


Dieter's patch contained actually a test but the patch introduced a new 
directory with the tests with I forget to "svn add".

Andreas

--On 7. Juli 2008 00:23:13 +0200 Philipp von Weitershausen 
<philipp at weitershausen.de> wrote:

> Andreas Jung wrote:
>> Log message for revision 88055:
>>   Launchpad #242851: applied patch for package normalization
> ...
>> Modified: zope.testing/branches/3.5/src/zope/testing/testrunner.py
>> ===================================================================
>> --- zope.testing/branches/3.5/src/zope/testing/testrunner.py	2008-07-06
>> 01:51:42 UTC (rev 88054) +++
>> zope.testing/branches/3.5/src/zope/testing/testrunner.py	2008-07-06
>> 06:34:08 UTC (rev 88055) @@ -2501,7 +2501,12 @@
>>                            ])
>>
>>      if options.package:
>> -        pkgmap = dict(options.test_path)
>> +        # DM 2008-06-25: filter out '--test-path' values as
>> +        #   they are not involved in package resolution
>> +        #pkgmap = dict(options.test_path)
>> +        pkgmap = dict([(path, '') for path in options.path]
>> +                      + (options.package_path or [])
>> +                      )
>>          options.package = [normalize_package(p, pkgmap)
>>                             for p in options.package]
>
> It would be good to clean patches of certain comments before they were
> applied. The fact that Dieter made this comment or the date is pretty
> irrelevant here. The line containing the old code can go as well.
>
> But most importantly, where are the tests?



-- 
ZOPYX Ltd. & Co. KG - Charlottenstr. 37/1 - 72070 Tübingen - Germany
Web: www.zopyx.com - Email: info at zopyx.com - Phone +49 - 7071 - 793376
Registergericht: Amtsgericht Stuttgart, Handelsregister A 381535
Geschäftsführer/Gesellschafter: ZOPYX Limited, Birmingham, UK
------------------------------------------------------------------------
E-Publishing, Python, Zope & Plone development, Consulting
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://mail.zope.org/pipermail/checkins/attachments/20080708/d76182d3/attachment.bin


More information about the Checkins mailing list