[Checkins] SVN: grokcore.view/trunk/src/grokcore/view/ Rename the
class that grokcore.view exposes to View. There's no need for
a base class
Philipp von Weitershausen
philikon at philikon.de
Sat Jul 19 22:07:52 EDT 2008
Log message for revision 88628:
Rename the class that grokcore.view exposes to View. There's no need for a base class
(e.g. ViewBase) I think. People should simply be able to subclass from
grokcore.view.View to write a Zope 3 browser view.
Cleanup some of the __call__ confusion.
Changed:
U grokcore.view/trunk/src/grokcore/view/__init__.py
U grokcore.view/trunk/src/grokcore/view/components.py
U grokcore.view/trunk/src/grokcore/view/tests/components.py
U grokcore.view/trunk/src/grokcore/view/tests/meta.py
-=-
Modified: grokcore.view/trunk/src/grokcore/view/__init__.py
===================================================================
--- grokcore.view/trunk/src/grokcore/view/__init__.py 2008-07-20 01:54:47 UTC (rev 88627)
+++ grokcore.view/trunk/src/grokcore/view/__init__.py 2008-07-20 02:07:52 UTC (rev 88628)
@@ -1,5 +1,5 @@
from grokcore.view.directive import layer, view, require, template, templatedir
from grokcore.view.util import url
-from grokcore.view.components import GrokView, Permission, GrokForm, Skin
+from grokcore.view.components import View, Permission, GrokForm, Skin
from grokcore.view.components import PageTemplate, PageTemplateFile
from grokcore.view.components import IGrokLayer
Modified: grokcore.view/trunk/src/grokcore/view/components.py
===================================================================
--- grokcore.view/trunk/src/grokcore/view/components.py 2008-07-20 01:54:47 UTC (rev 88627)
+++ grokcore.view/trunk/src/grokcore/view/components.py 2008-07-20 02:07:52 UTC (rev 88628)
@@ -29,28 +29,16 @@
pass
-class GrokView(BrowserPage):
+class View(BrowserPage):
def __init__(self, context, request):
- super(GrokView, self).__init__(context, request)
+ super(View, self).__init__(context, request)
self.__name__ = self.__view_name__
self.static = component.queryAdapter(
self.request,
interface.Interface,
name=self.module_info.package_dotted_name)
- def _update_and_render(self):
- mapply(self.update, (), self.request)
- if self.request.response.getStatus() in (302, 303):
- # A redirect was triggered somewhere in update(). Don't
- # continue rendering the template or doing anything else.
- return
-
- template = getattr(self, 'template', None)
- if template is not None:
- return self._render_template()
- return mapply(self.render, (), self.request)
-
def _render_template(self):
return self.template.render(self)
Modified: grokcore.view/trunk/src/grokcore/view/tests/components.py
===================================================================
--- grokcore.view/trunk/src/grokcore/view/tests/components.py 2008-07-20 01:54:47 UTC (rev 88627)
+++ grokcore.view/trunk/src/grokcore/view/tests/components.py 2008-07-20 02:07:52 UTC (rev 88628)
@@ -12,11 +12,8 @@
interface.implements(IContext)
-class View(grokcore.view.GrokView):
+class View(grokcore.view.View):
- def __call__(self):
- return self._update_and_render()
-
def __getitem__(self, key):
# This is BBB code for Zope page templates only:
if not isinstance(self.template, PageTemplate):
Modified: grokcore.view/trunk/src/grokcore/view/tests/meta.py
===================================================================
--- grokcore.view/trunk/src/grokcore/view/tests/meta.py 2008-07-20 01:54:47 UTC (rev 88627)
+++ grokcore.view/trunk/src/grokcore/view/tests/meta.py 2008-07-20 02:07:52 UTC (rev 88628)
@@ -40,7 +40,7 @@
class ViewGrokker(ViewGrokkerBase):
- martian.component(grokcore.view.GrokView)
+ martian.component(grokcore.view.View)
def protectName(self, config, factory, permission):
config.action(
More information about the Checkins
mailing list