[Checkins] SVN: grokcore.view/trunk/src/grokcore/view/ Move __getitem__ method (even though it may be deprecated) into

[Philipp von Weitershausen]

Log message for revision 88634:
  Move __getitem__ method (even though it may be deprecated) into
  grokcore.view.View to make grok.View even leaner.
  

Changed:
  U   grokcore.view/trunk/src/grokcore/view/components.py
  U   grokcore.view/trunk/src/grokcore/view/tests/components.py

-=-
Modified: grokcore.view/trunk/src/grokcore/view/components.py
===================================================================
--- grokcore.view/trunk/src/grokcore/view/components.py	2008-07-20 02:29:40 UTC (rev 88633)
+++ grokcore.view/trunk/src/grokcore/view/components.py	2008-07-20 02:33:39 UTC (rev 88634)
@@ -1,5 +1,6 @@
 import os
 import sys
+import warnings
 
 from zope import component
 from zope import interface
@@ -13,7 +14,6 @@
     PageTemplateResourceFactory
 
 import martian
-
 from grokcore.view import util, interfaces
 
 
@@ -102,6 +102,20 @@
         namespace['view'] = self
         return namespace
 
+    def __getitem__(self, key):
+        # This is BBB code for Zope page templates only:
+        if not isinstance(self.template, PageTemplate):
+            raise AttributeError("View has no item %s" % key)
+
+        value = self.template._template.macros[key]
+        # When this deprecation is done with, this whole __getitem__ can
+        # be removed.
+        warnings.warn("Calling macros directly on the view is deprecated. "
+                      "Please use context/@@viewname/macros/macroname\n"
+                      "View %r, macro %s" % (self, key),
+                      DeprecationWarning, 1)
+        return value
+
     def application_url(self, name=None):
         raise NotImplementedError
 

Modified: grokcore.view/trunk/src/grokcore/view/tests/components.py
===================================================================
--- grokcore.view/trunk/src/grokcore/view/tests/components.py	2008-07-20 02:29:40 UTC (rev 88633)
+++ grokcore.view/trunk/src/grokcore/view/tests/components.py	2008-07-20 02:33:39 UTC (rev 88634)
@@ -1,11 +1,6 @@
-import warnings
-
 from zope import interface
-
 from grokcore.component.interfaces import IContext
-
 import grokcore.view
-from grokcore.view import PageTemplate
 
 
 class Model(object):
@@ -13,17 +8,4 @@
 
 
 class View(grokcore.view.View):
-
-    def __getitem__(self, key):
-        # This is BBB code for Zope page templates only:
-        if not isinstance(self.template, PageTemplate):
-            raise AttributeError("View has no item %s" % key)
-
-        value = self.template._template.macros[key]
-        # When this deprecation is done with, this whole __getitem__ can
-        # be removed.
-        warnings.warn("Calling macros directly on the view is deprecated. "
-                      "Please use context/@@viewname/macros/macroname\n"
-                      "View %r, macro %s" % (self, key),
-                      DeprecationWarning, 1)
-        return value
+    pass