[Checkins] SVN: z3c.form/trunk/ - Bug: The ``applyChanges()``
method in group forms did not return a changes
Stephan Richter
srichter at cosmos.phy.tufts.edu
Thu May 29 14:07:13 EDT 2008
Log message for revision 87052:
- Bug: The ``applyChanges()`` method in group forms did not return a changes
dictionary, but simply a boolean. This is now fixed and the group form
changes are now merged with the main form changes.
Changed:
U z3c.form/trunk/CHANGES.txt
U z3c.form/trunk/src/z3c/form/group.py
-=-
Modified: z3c.form/trunk/CHANGES.txt
===================================================================
--- z3c.form/trunk/CHANGES.txt 2008-05-29 18:05:18 UTC (rev 87051)
+++ z3c.form/trunk/CHANGES.txt 2008-05-29 18:07:12 UTC (rev 87052)
@@ -9,6 +9,10 @@
that generates readable ids for use with css selectors from any
unicode string.
+- Bug: The ``applyChanges()`` method in group forms did not return a changes
+ dictionary, but simply a boolean. This is now fixed and the group form
+ changes are now merged with the main form changes.
+
- Bug: Display widgets did not set the style attribute if it was
available, even though the input widgets did set the style attribute.
Modified: z3c.form/trunk/src/z3c/form/group.py
===================================================================
--- z3c.form/trunk/src/z3c/form/group.py 2008-05-29 18:05:18 UTC (rev 87051)
+++ z3c.form/trunk/src/z3c/form/group.py 2008-05-29 18:07:12 UTC (rev 87052)
@@ -59,13 +59,12 @@
def applyChanges(self, data):
'''See interfaces.IEditForm'''
- changed = False
content = self.getContent()
- form.applyChanges(self, content, data)
+ changed = form.applyChanges(self, content, data)
for group in self.groups:
groupContent = group.getContent()
groupChanged = form.applyChanges(group, groupContent, data)
- changed = changed or groupChanged
+ changed.update(groupChanged)
if changed:
zope.event.notify(
zope.lifecycleevent.ObjectModifiedEvent(content))
More information about the Checkins
mailing list