[Checkins] SVN: zope.sendmail/trunk/src/zope/sendmail/ close smtp connection on failed quit

Zvezdan Petkovic zvezdan at zope.com
Sun Nov 2 17:01:14 EST 2008


On Nov 1, 2008, at 3:51 PM, Adam Groszer wrote:

> Log message for revision 92747:
>  close smtp connection on failed quit
>
> Changed:
>  U   zope.sendmail/trunk/src/zope/sendmail/mailer.py
>  U   zope.sendmail/trunk/src/zope/sendmail/tests/test_mailer.py

snipped

> +            failOnQuit = False
> +

All other attributes in this module follow PEP-8 naming convention  
(fail_on_quit).  Should we keep it consistent?

>
>             def __init__(myself, h, p):
>                 myself.hostname = h
>                 myself.port = p
> +                myself.quited = False
> +                myself.closed = False

The type "quited" is used in several places in this checkin.

It should be either "quit" or "quitted".
Also, "have_quit" could be used (myself.have_quit) to distinguish  
between the present and past forms of "quit".



More information about the Checkins mailing list