[Checkins] SVN: Products.GenericSetup/trunk/Products/GenericSetup/tool.py Remove a conditional which made it impossible to have empty upgrade profiles

Wichert Akkerman wichert at wiggy.net
Mon Nov 3 10:56:24 EST 2008


Log message for revision 92758:
  Remove a conditional which made it impossible to have empty upgrade profiles
  

Changed:
  U   Products.GenericSetup/trunk/Products/GenericSetup/tool.py

-=-
Modified: Products.GenericSetup/trunk/Products/GenericSetup/tool.py
===================================================================
--- Products.GenericSetup/trunk/Products/GenericSetup/tool.py	2008-11-03 12:50:32 UTC (rev 92757)
+++ Products.GenericSetup/trunk/Products/GenericSetup/tool.py	2008-11-03 15:56:20 UTC (rev 92758)
@@ -868,7 +868,6 @@
         logger = logging.getLogger('GenericSetup')
         steps_to_run = request.form.get('upgrades', [])
         profile_id = request.get('profile_id', '')
-        step = None
         for step_id in steps_to_run:
             step = _upgrade_registry.getUpgradeStep(profile_id, step_id)
             if step is not None:
@@ -879,8 +878,7 @@
 
         # We update the profile version to the last one we have reached
         # with runnning an upgrade step.
-        if step is not None:
-            self.setLastVersionForProfile(profile_id, step.dest)
+        self.setLastVersionForProfile(profile_id, step.dest)
 
         url = self.absolute_url()
         request.RESPONSE.redirect("%s/manage_upgrades?saved=%s" % (url, profile_id))



More information about the Checkins mailing list