[Checkins] SVN: zc.table/trunk/src/zc/table/column.py Use a sort with a key parameter instead of decoration of the list.
Ignas Mikalajënas
ignas at pov.lt
Tue Oct 21 08:11:37 EDT 2008
Log message for revision 92423:
Use a sort with a key parameter instead of decoration of the list.
Changed:
U zc.table/trunk/src/zc/table/column.py
-=-
Modified: zc.table/trunk/src/zc/table/column.py
===================================================================
--- zc.table/trunk/src/zc/table/column.py 2008-10-21 10:47:38 UTC (rev 92422)
+++ zc.table/trunk/src/zc/table/column.py 2008-10-21 12:11:33 UTC (rev 92423)
@@ -60,11 +60,11 @@
items = list(items) # don't mutate original
getSortKey = self.getSortKey
- # let's do decorate, sort, undecorate trick here to conserve time
- tmp_items = [(getSortKey(item, formatter), item) for item in items]
- tmp_items.sort(lambda a, b: multiplier*cmp(a[0], b[0]))
+ items.sort(
+ cmp=lambda a, b: multiplier*cmp(a, b),
+ key=lambda item: getSortKey(item, formatter))
- return [item for key, item in tmp_items]
+ return items
def sort(self, items, formatter, start, stop, sorters):
return self._sort(items, formatter, start, stop, sorters, 1)
More information about the Checkins
mailing list