[Checkins] SVN: z3c.menu.ready2go/trunk/ Add support for viewName's that start with ``@@``.

Dan Korostelev nadako at gmail.com
Tue Oct 28 08:11:58 EDT 2008


Log message for revision 92654:
  Add support for viewName's that start with ``@@``.

Changed:
  U   z3c.menu.ready2go/trunk/CHANGES.txt
  U   z3c.menu.ready2go/trunk/src/z3c/menu/ready2go/README.txt
  U   z3c.menu.ready2go/trunk/src/z3c/menu/ready2go/checker.py

-=-
Modified: z3c.menu.ready2go/trunk/CHANGES.txt
===================================================================
--- z3c.menu.ready2go/trunk/CHANGES.txt	2008-10-28 10:23:44 UTC (rev 92653)
+++ z3c.menu.ready2go/trunk/CHANGES.txt	2008-10-28 12:11:57 UTC (rev 92654)
@@ -6,7 +6,8 @@
 Version 0.5.1dev (unreleased)
 -----------------------------
 
-- ...
+- Add support for viewName's that start with ``@@``. They are now processed
+  properly by the ViewNameSelectedChecker.
 
 
 Version 0.5.0 (2008-04-11)

Modified: z3c.menu.ready2go/trunk/src/z3c/menu/ready2go/README.txt
===================================================================
--- z3c.menu.ready2go/trunk/src/z3c/menu/ready2go/README.txt	2008-10-28 10:23:44 UTC (rev 92653)
+++ z3c.menu.ready2go/trunk/src/z3c/menu/ready2go/README.txt	2008-10-28 12:11:57 UTC (rev 92654)
@@ -277,6 +277,20 @@
     <a href="http://127.0.0.1/site/content/context.html"><span>My Context</span></a>
   </li>
 
+Also, let's check that menu item is marked selected even if we provided a viewName in
+the ``@@context.html`` form: 
+
+  >>> MyContextMenuItem.viewName = '@@context.html'
+  >>> contextMenu.update()
+  >>> print contextMenu.render()
+  <li class="selected">
+    <a href="http://127.0.0.1/site/content/@@context.html"><span>My Context</span></a>
+  </li>
+
+Okay, change viewName back to ``context.html`` for further tests:
+
+  >>> MyContextMenuItem.viewName = 'context.html'
+
 Now add a second context menu item and check if we can use the cssInActive
 argument which is normaly a empty string:
 
@@ -304,7 +318,6 @@
     <a href="http://127.0.0.1/site/content/inActive.html"><span>In Active</span></a>
   </li>
 
-
 AddMenu
 -------
 

Modified: z3c.menu.ready2go/trunk/src/z3c/menu/ready2go/checker.py
===================================================================
--- z3c.menu.ready2go/trunk/src/z3c/menu/ready2go/checker.py	2008-10-28 10:23:44 UTC (rev 92653)
+++ z3c.menu.ready2go/trunk/src/z3c/menu/ready2go/checker.py	2008-10-28 12:11:57 UTC (rev 92654)
@@ -62,7 +62,10 @@
     @property
     def selected(self):
         """Selected if also view name compares."""
-        if self.view.__name__ == self.item.viewName:
+        viewName = self.item.viewName
+        if viewName.startswith('@@'):
+            viewName = viewName[2:]
+        if self.view.__name__ == viewName:
             return True
         return False
 



More information about the Checkins mailing list