[Checkins] SVN: zc.zservertracelog/branches/alex-extensions-2/ fixed bug where log entries could be split by messages with newlines.

[Alex Smith]

Log message for revision 91094:
  
  fixed bug where log entries could be split by messages with newlines.
  

Changed:
  U   zc.zservertracelog/branches/alex-extensions-2/CHANGES.txt
  U   zc.zservertracelog/branches/alex-extensions-2/src/zc/zservertracelog/README.txt
  U   zc.zservertracelog/branches/alex-extensions-2/src/zc/zservertracelog/tracelog.py

-=-
Modified: zc.zservertracelog/branches/alex-extensions-2/CHANGES.txt
===================================================================
--- zc.zservertracelog/branches/alex-extensions-2/CHANGES.txt	2008-09-12 15:47:55 UTC (rev 91093)
+++ zc.zservertracelog/branches/alex-extensions-2/CHANGES.txt	2008-09-12 15:48:51 UTC (rev 91094)
@@ -9,4 +9,5 @@
 
 * added automated tests.
 
-* added hooks for tracelog extensions.
+* fixed bug where log entries could be split by messages containing newline
+  characters.

Modified: zc.zservertracelog/branches/alex-extensions-2/src/zc/zservertracelog/README.txt
===================================================================
--- zc.zservertracelog/branches/alex-extensions-2/src/zc/zservertracelog/README.txt	2008-09-12 15:47:55 UTC (rev 91093)
+++ zc.zservertracelog/branches/alex-extensions-2/src/zc/zservertracelog/README.txt	2008-09-12 15:48:51 UTC (rev 91094)
@@ -118,3 +118,23 @@
 Let's clean up before moving on.
 
     >>> faux_app.app_hook = None
+
+
+Log Messages Containing Line Breaks
+===================================
+
+Messages to the tracelog that contain newline characters will not split a log
+entry into multiple lines.
+
+    >>> req2 = """\
+    ... GET /test-req2/%0Aohnoes/ HTTP/1.1
+    ... Host: www.example.com/linebreak
+    ...
+    ... """
+
+    >>> invokeRequest(req2)
+    B 21598352 2008-09-12T11:40:27 GET /test-req2/\nohnoes/
+    I 21598352 2008-09-12T11:40:27 0
+    C 21598352 2008-09-12T11:40:27
+    A 21598352 2008-09-12T11:40:27 200 ?
+    E 21598352 2008-09-12T11:40:27

Modified: zc.zservertracelog/branches/alex-extensions-2/src/zc/zservertracelog/tracelog.py
===================================================================
--- zc.zservertracelog/branches/alex-extensions-2/src/zc/zservertracelog/tracelog.py	2008-09-12 15:47:55 UTC (rev 91093)
+++ zc.zservertracelog/branches/alex-extensions-2/src/zc/zservertracelog/tracelog.py	2008-09-12 15:48:51 UTC (rev 91094)
@@ -66,7 +66,7 @@
             entry += ' %s' % self.extension_id
 
         if msg:
-            entry += ' %s' % msg
+            entry += ' %s' % repr(msg)[1:-1]
 
         tracelog.info(entry)