[Checkins] SVN: zc.z3monitor/branches/0.6/src/zc/z3monitor/ Bugs Fixed: The z3monitor server lacked a handle_close method, which caused

Jim Fulton jim at zope.com
Mon Sep 15 18:05:32 EDT 2008


Log message for revision 91175:
  Bugs Fixed: The z3monitor server lacked a handle_close method, which caused
    errors to get logged when users closed connections before giving
    commands.
  

Changed:
  U   zc.z3monitor/branches/0.6/src/zc/z3monitor/CHANGES.txt
  U   zc.z3monitor/branches/0.6/src/zc/z3monitor/README.txt
  U   zc.z3monitor/branches/0.6/src/zc/z3monitor/__init__.py

-=-
Modified: zc.z3monitor/branches/0.6/src/zc/z3monitor/CHANGES.txt
===================================================================
--- zc.z3monitor/branches/0.6/src/zc/z3monitor/CHANGES.txt	2008-09-15 22:00:44 UTC (rev 91174)
+++ zc.z3monitor/branches/0.6/src/zc/z3monitor/CHANGES.txt	2008-09-15 22:05:31 UTC (rev 91175)
@@ -14,6 +14,15 @@
 * The ``monitor`` command takes an optional database argument (after the legacy
   ``long`` argument).
 
+0.5.1 (2008-09-15)
+==================
+
+Bugs Fixed:
+
+- The z3monitor server lacked a handle_close method, which caused
+  errors to get logged when users closed connections before giving
+  commands. 
+
 0.5.0 (2008-4-4)
 ================
 

Modified: zc.z3monitor/branches/0.6/src/zc/z3monitor/README.txt
===================================================================
--- zc.z3monitor/branches/0.6/src/zc/z3monitor/README.txt	2008-09-15 22:00:44 UTC (rev 91174)
+++ zc.z3monitor/branches/0.6/src/zc/z3monitor/README.txt	2008-09-15 22:05:31 UTC (rev 91175)
@@ -365,3 +365,9 @@
     False 
     -> CLOSE
 
+
+.. Edge cases
+
+   Closing the connection:
+
+   >>> connection.test_close('test')

Modified: zc.z3monitor/branches/0.6/src/zc/z3monitor/__init__.py
===================================================================
--- zc.z3monitor/branches/0.6/src/zc/z3monitor/__init__.py	2008-09-15 22:00:44 UTC (rev 91174)
+++ zc.z3monitor/branches/0.6/src/zc/z3monitor/__init__.py	2008-09-15 22:05:31 UTC (rev 91175)
@@ -68,7 +68,10 @@
         if self.mode is QUIT_MARKER:
             connection.write(zc.ngi.END_OF_DATA)
 
+    def handle_close(self, connection, reason):
+        pass                            # Don't care
 
+
 def interactive(connection):
     """Turn on monitor's interactive mode
     
@@ -88,6 +91,7 @@
     connection.write('Goodbye.\n')
     return QUIT_MARKER
 
+
 def help(connection, command_name=None):
     """Get help about server commands
 



More information about the Checkins mailing list