[Checkins] SVN: z3c.formwidget.query/trunk/src/z3c/formwidget/query/ Don't try to be too clever. The underlying widget knows best, and trying to intercept that it returns leads to funky inconsistencies within z3c.form

Martin Aspeli optilude at gmx.net
Sat Apr 4 11:53:06 EDT 2009


Log message for revision 98857:
  Don't try to be too clever. The underlying widget knows best, and trying to intercept that it returns leads to funky inconsistencies within z3c.form

Changed:
  U   z3c.formwidget.query/trunk/src/z3c/formwidget/query/README.txt
  U   z3c.formwidget.query/trunk/src/z3c/formwidget/query/widget.py

-=-
Modified: z3c.formwidget.query/trunk/src/z3c/formwidget/query/README.txt
===================================================================
--- z3c.formwidget.query/trunk/src/z3c/formwidget/query/README.txt	2009-04-04 06:27:02 UTC (rev 98856)
+++ z3c.formwidget.query/trunk/src/z3c/formwidget/query/README.txt	2009-04-04 15:53:05 UTC (rev 98857)
@@ -214,10 +214,10 @@
 
   >>> widget = setupMultiWidget(cities, route, request)
 
-We expect an unchecked box.
+We expect the checkbox to be gone.
 
   >>> 'type="checkbox"' in widget()
-  True
+  False
   
   >>> 'checked="checked"' in widget()
   False

Modified: z3c.formwidget.query/trunk/src/z3c/formwidget/query/widget.py
===================================================================
--- z3c.formwidget.query/trunk/src/z3c/formwidget/query/widget.py	2009-04-04 06:27:02 UTC (rev 98856)
+++ z3c.formwidget.query/trunk/src/z3c/formwidget/query/widget.py	2009-04-04 15:53:05 UTC (rev 98857)
@@ -160,13 +160,7 @@
                 })
 
     def extract(self, default=z3c.form.interfaces.NOVALUE):
-        value = self.extractQueryWidget(default)
-        if value is z3c.form.interfaces.NOVALUE:
-            return value
-        elif len(value) == 0:
-            return default
-        else:
-            return value
+        return self.extractQueryWidget(default)
         
     def render(self):
         subform = self.subform



More information about the Checkins mailing list