[Checkins] SVN: zope.testing/trunk/ - fix test failure on Python 2.4 because of slight difference in the way

Christian Theune ct at gocept.com
Fri Apr 17 18:44:09 EDT 2009


On Mon, 2009-04-13 at 11:43 -0400, Benji York wrote:
> Log message for revision 99151:
>   - fix test failure on Python 2.4 because of slight difference in the way
>     coverage is reported (__init__ files with only a single comment line are now
>     not reported)
>   - fixed bug that caused the test runner to hang when running subprocesses (as a
>     result Python 2.3 is no longer supported).

Ah, great. I was working towards a fix as well, but hadn't had time to
fix that. For me this only appeared on 2.5, not 2.4, same for you?

Something that I also see: the output of subprocesses is only displayed
after the subprocess finished which also gives the impression of hangs
also it just takes time.
 
> +# unfortunately there is a zope.testing.testrunner.subprocess module that we
> +# need to avoid; also, we want to support Python 2.4, which doesn't have
> +# # from __future__ import absolute_import, so we use a hack instead
> +import imp
> +subprocess = imp.load_module('subprocess', *imp.find_module('subprocess'))
> +

I found that as well. I would also be happy to rename the local
subprocess module as it's really an implementation detail.

Christian

-- 
Christian Theune · ct at gocept.com
gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
http://gocept.com · tel +49 345 1229889 7 · fax +49 345 1229889 1
Zope and Plone consulting and development
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://mail.zope.org/pipermail/checkins/attachments/20090418/64eca24c/attachment.bin 


More information about the Checkins mailing list