[Checkins] SVN: z3c.schemadiff/trunk/ Use field.query instead of getattr

Nikolay Kim fafhrd91 at gmail.com
Fri Aug 14 06:40:52 EDT 2009


Log message for revision 102761:
  Use field.query instead of getattr

Changed:
  U   z3c.schemadiff/trunk/CHANGES.txt
  U   z3c.schemadiff/trunk/src/z3c/schemadiff/schema.py

-=-
Modified: z3c.schemadiff/trunk/CHANGES.txt
===================================================================
--- z3c.schemadiff/trunk/CHANGES.txt	2009-08-14 09:59:46 UTC (rev 102760)
+++ z3c.schemadiff/trunk/CHANGES.txt	2009-08-14 10:40:52 UTC (rev 102761)
@@ -12,6 +12,9 @@
 
 - Drop field if either value is ``None``. [malthe]
 
+- Use field.query instead of getattr
+
+
 0.1 (2008-04-30)
 ----------------
 

Modified: z3c.schemadiff/trunk/src/z3c/schemadiff/schema.py
===================================================================
--- z3c.schemadiff/trunk/src/z3c/schemadiff/schema.py	2009-08-14 09:59:46 UTC (rev 102760)
+++ z3c.schemadiff/trunk/src/z3c/schemadiff/schema.py	2009-08-14 10:40:52 UTC (rev 102761)
@@ -18,8 +18,8 @@
             except TypeError:
                 continue
 
-            source_value = getattr(source, name, field.default)
-            target_value = getattr(target, name, field.default)
+            source_value = bound.query(source, field.default)
+            target_value = bound.query(target, field.default)
 
             if source_value is None or target_value is None:
                 continue



More information about the Checkins mailing list