[Checkins] SVN: z3c.formui/trunk/ Don't show required info hint if there's no required fields.
Dan Korostelev
nadako at gmail.com
Thu Aug 20 07:30:36 EDT 2009
Log message for revision 103000:
Don't show required info hint if there's no required fields.
Changed:
U z3c.formui/trunk/CHANGES.txt
U z3c.formui/trunk/setup.py
U z3c.formui/trunk/src/z3c/formui/README.txt
U z3c.formui/trunk/src/z3c/formui/div-form.pt
U z3c.formui/trunk/src/z3c/formui/table-form.pt
-=-
Modified: z3c.formui/trunk/CHANGES.txt
===================================================================
--- z3c.formui/trunk/CHANGES.txt 2009-08-20 11:12:53 UTC (rev 102999)
+++ z3c.formui/trunk/CHANGES.txt 2009-08-20 11:30:35 UTC (rev 103000)
@@ -5,7 +5,7 @@
2.1.0 (unreleased)
------------------
-- ...
+- Don't show required info hint if there's no required fields.
2.0.0 (2009-06-14)
------------------
Modified: z3c.formui/trunk/setup.py
===================================================================
--- z3c.formui/trunk/setup.py 2009-08-20 11:12:53 UTC (rev 102999)
+++ z3c.formui/trunk/setup.py 2009-08-20 11:30:35 UTC (rev 103000)
@@ -58,7 +58,7 @@
),
install_requires = [
'setuptools',
- 'z3c.form',
+ 'z3c.form>=2.0',
'z3c.macro',
'z3c.template',
'zope.component',
Modified: z3c.formui/trunk/src/z3c/formui/README.txt
===================================================================
--- z3c.formui/trunk/src/z3c/formui/README.txt 2009-08-20 11:12:53 UTC (rev 102999)
+++ z3c.formui/trunk/src/z3c/formui/README.txt 2009-08-20 11:30:35 UTC (rev 103000)
@@ -846,27 +846,52 @@
Redirection
-----------
- The form doesn't bother rendering itself and its layout when
- request is a redirection as the rendering doesn't make any sense with
- browser requests in that case. Let's create a view that does a
- redirection in its update method:
+The form doesn't bother rendering itself and its layout when
+request is a redirection as the rendering doesn't make any sense with
+browser requests in that case. Let's create a view that does a
+redirection in its update method:
- >>> class RedirectingView(PersonEditForm):
- ... def update(self):
- ... super(RedirectingView, self).update()
- ... self.request.response.redirect('http://www.google.com/')
+ >>> class RedirectingView(PersonEditForm):
+ ... def update(self):
+ ... super(RedirectingView, self).update()
+ ... self.request.response.redirect('http://www.google.com/')
- It will return an empty string when called as a browser page.
+It will return an empty string when called as a browser page.
- >>> redirectView = RedirectingView(person, divRequest)
- >>> redirectView() == ''
- True
+ >>> redirectView = RedirectingView(person, divRequest)
+ >>> redirectView() == ''
+ True
- However, the ``render`` method will render form's template as usual:
+However, the ``render`` method will render form's template as usual:
- >>> '<div class="viewspace">' in redirectView.render()
- True
+ >>> '<div class="viewspace">' in redirectView.render()
+ True
+No required fields
+------------------
+
+If there no required fields in the form, standard templates won't render
+the "required-info" hint.
+
+ >>> class IAdditionalInfo(zope.interface.Interface):
+ ...
+ ... location = zope.schema.TextLine(title=u'Location', required=False)
+ ... about = zope.schema.Text(title=u'About', required=False)
+
+ >>> class AdditionalInfoForm(form.AddForm):
+ ...
+ ... fields = field.Fields(IAdditionalInfo)
+
+ >>> additionalInfoForm = AdditionalInfoForm(root, divRequest)
+ >>> additionalInfoForm.update()
+ >>> '<div class="required-info">' in additionalInfoForm.render()
+ False
+
+ >>> additionalInfoForm = AdditionalInfoForm(root, tableRequest)
+ >>> additionalInfoForm.update()
+ >>> '<div class="required-info">' in additionalInfoForm.render()
+ False
+
Cleanup
-------
Modified: z3c.formui/trunk/src/z3c/formui/div-form.pt
===================================================================
--- z3c.formui/trunk/src/z3c/formui/div-form.pt 2009-08-20 11:12:53 UTC (rev 102999)
+++ z3c.formui/trunk/src/z3c/formui/div-form.pt 2009-08-20 11:30:35 UTC (rev 103000)
@@ -18,6 +18,7 @@
</metal:block>
<metal:block define-slot="info">
<div class="required-info"
+ tal:condition="view/widgets/hasRequiredFields"
metal:define-macro="required-info">
<span class="required">*</span>
– required
Modified: z3c.formui/trunk/src/z3c/formui/table-form.pt
===================================================================
--- z3c.formui/trunk/src/z3c/formui/table-form.pt 2009-08-20 11:12:53 UTC (rev 102999)
+++ z3c.formui/trunk/src/z3c/formui/table-form.pt 2009-08-20 11:30:35 UTC (rev 103000)
@@ -18,6 +18,7 @@
</metal:block>
<metal:block define-slot="info">
<div class="required-info"
+ tal:condition="view/widgets/hasRequiredFields"
metal:define-macro="required-info">
<span class="required">*</span>
– required
More information about the Checkins
mailing list