[Checkins] SVN: z3c.dependencychecker/trunk/ Dependencychecker is now case insensitive as pypi is too.

Reinout van Rees reinout at vanrees.org
Thu Dec 24 05:19:55 EST 2009


Log message for revision 107051:
  Dependencychecker is now case insensitive as pypi is too.

Changed:
  U   z3c.dependencychecker/trunk/CHANGES.txt
  U   z3c.dependencychecker/trunk/src/z3c/dependencychecker/USAGE.txt
  U   z3c.dependencychecker/trunk/src/z3c/dependencychecker/dependencychecker.py
  U   z3c.dependencychecker/trunk/src/z3c/dependencychecker/tests/dependencychecker.txt
  U   z3c.dependencychecker/trunk/src/z3c/dependencychecker/tests/sample1/setup.py_in
  U   z3c.dependencychecker/trunk/src/z3c/dependencychecker/tests/sample1/src/sample1.egg-info_in/requires.txt

-=-
Modified: z3c.dependencychecker/trunk/CHANGES.txt
===================================================================
--- z3c.dependencychecker/trunk/CHANGES.txt	2009-12-24 08:22:17 UTC (rev 107050)
+++ z3c.dependencychecker/trunk/CHANGES.txt	2009-12-24 10:19:55 UTC (rev 107051)
@@ -4,6 +4,8 @@
 1.1 (unreleased)
 ----------------
 
+- Dependencychecker is now case insensitive as pypi is too.
+
 - Using optparse for parsing commandline now.  Added --help and --version.
 
 

Modified: z3c.dependencychecker/trunk/src/z3c/dependencychecker/USAGE.txt
===================================================================
--- z3c.dependencychecker/trunk/src/z3c/dependencychecker/USAGE.txt	2009-12-24 08:22:17 UTC (rev 107050)
+++ z3c.dependencychecker/trunk/src/z3c/dependencychecker/USAGE.txt	2009-12-24 10:19:55 UTC (rev 107051)
@@ -58,7 +58,7 @@
     <BLANKLINE>
     Requirements that should be test requirements
     =============================================
-         needed.by.test
+         Needed.By.Test
     <BLANKLINE>
     Unneeded test requirements
     ==========================

Modified: z3c.dependencychecker/trunk/src/z3c/dependencychecker/dependencychecker.py
===================================================================
--- z3c.dependencychecker/trunk/src/z3c/dependencychecker/dependencychecker.py	2009-12-24 08:22:17 UTC (rev 107050)
+++ z3c.dependencychecker/trunk/src/z3c/dependencychecker/dependencychecker.py	2009-12-24 10:19:55 UTC (rev 107051)
@@ -150,9 +150,9 @@
     for needed in imports:
         found = False
         for req in required:
-            if req == needed:
+            if req.lower() == needed.lower():
                 found = True
-            if needed.startswith(req + '.'):
+            if needed.lower().startswith(req.lower() + '.'):
                 # 're' should not match 'reinout.something', that's why we
                 # check with an extra dot.
                 found = True
@@ -175,7 +175,7 @@
     for req in required:
         found = False
         for module in imports:
-            if module.startswith(req):
+            if module.lower().startswith(req.lower()):
                 found = True
         if not found:
             unneeded.append(req)

Modified: z3c.dependencychecker/trunk/src/z3c/dependencychecker/tests/dependencychecker.txt
===================================================================
--- z3c.dependencychecker/trunk/src/z3c/dependencychecker/tests/dependencychecker.txt	2009-12-24 08:22:17 UTC (rev 107050)
+++ z3c.dependencychecker/trunk/src/z3c/dependencychecker/tests/dependencychecker.txt	2009-12-24 10:19:55 UTC (rev 107051)
@@ -46,6 +46,9 @@
     >>> required = ['some.thing']
     >>> dependencychecker.filter_missing(imports, required)
     []
+    >>> required = ['Some.Thing'] # case insensitive
+    >>> dependencychecker.filter_missing(imports, required)
+    []
 
 But a requirement that is more specific than the import fails:
 

Modified: z3c.dependencychecker/trunk/src/z3c/dependencychecker/tests/sample1/setup.py_in
===================================================================
--- z3c.dependencychecker/trunk/src/z3c/dependencychecker/tests/sample1/setup.py_in	2009-12-24 08:22:17 UTC (rev 107050)
+++ z3c.dependencychecker/trunk/src/z3c/dependencychecker/tests/sample1/setup.py_in	2009-12-24 10:19:55 UTC (rev 107051)
@@ -21,7 +21,8 @@
           'setuptools',
           'zest.releaser',
           'unneeded.req',
-          'needed.by.test',
+          'Needed.By.Test',
+          # ^^^ Note: capitalized to test case-insensitive pypi
           'needed.by.zcml',
           ],
       extras_require = {

Modified: z3c.dependencychecker/trunk/src/z3c/dependencychecker/tests/sample1/src/sample1.egg-info_in/requires.txt
===================================================================
--- z3c.dependencychecker/trunk/src/z3c/dependencychecker/tests/sample1/src/sample1.egg-info_in/requires.txt	2009-12-24 08:22:17 UTC (rev 107050)
+++ z3c.dependencychecker/trunk/src/z3c/dependencychecker/tests/sample1/src/sample1.egg-info_in/requires.txt	2009-12-24 10:19:55 UTC (rev 107051)
@@ -1,7 +1,7 @@
 setuptools
 zest.releaser
 unneeded.req
-needed.by.test
+Needed.By.Test
 needed.by.zcml
 
 [test]



More information about the checkins mailing list